Giter Site home page Giter Site logo

Comments (2)

ebidel avatar ebidel commented on June 8, 2024

Yea, the iframe embedding a demo is kinda hacky. I wanted to have every page be standalone and have the server send the correct headers, but it was easier to embed the demos in an iframe and toggle policies via allow :)

from feature-policy-demos.

ehsan-karamad avatar ehsan-karamad commented on June 8, 2024

I think even if the server would run and set the header to something like vertical-scroll 'none' we'd still have some issues to properly explain what the feature demos. vertical-scroll is mostly meaningful in dealing with embedded content.

I can see two solutions (there is possibly more of course):

  • Get sample pages apply the change to a nested <iframe>. This is basically adding an <iframe> layer which makes some preparations before loading the actual test <iframe>. Some elements such as feature-allow-banner would have to be moved to the inner most frame. The general details and policy descriptions could (optionally) stay in the middle <iframe>.

  • Add an embedder page initialization step which will be overridden for each policy (only vertical-scroll perhaps).

In all these two cases all we need to do for vertical-scroll is to add some spacer above or below the test frame so that it is quite visible what the feature does.

from feature-policy-demos.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.