Comments (6)
For some reason the native feature "thinks" the text is unlinkable:
However, a manually created link works just fine: https://service.unece.org/trade/locode/gb.htm#:~:text=NRW.
The extension blocks the page and the tab becomes unresponsive.
I have filed https://crbug.com/1465883. The native Chrome implementation and the extension use essentially the same algorithm for creating links. Looks like there's an issue.
from link-to-text-fragment.
If you ever need to wait for a link to be created, something is wrong with the algorithm, which is outside of this repo (see the link to the algorithm repo above). Also, there's no way to know how long you'd have to wait, so at best, we could show a meaningless spinner.
from link-to-text-fragment.
Missing context: the extension uses the algorithm implemented in https://github.com/GoogleChromeLabs/text-fragments-polyfill.
from link-to-text-fragment.
@tomayac, why close the issue? I still think that a progress indicator would be really useful, as would asynchronous operations (although perhaps better in a separate issue?)
from link-to-text-fragment.
Yeah, @tomayac, even a spinner would have made diagnosing the issue easier.
from link-to-text-fragment.
This was really an exceptional case, where for some reason the entire page got blocked. The Chrome bug is the place to star if you want to follow up. Thank you.
from link-to-text-fragment.
Related Issues (20)
- Fragment + directive-delimited URIs don't function. HOT 3
- Duplicates selected text into clipboard (instead of URI) at specific URI. HOT 4
- Broken formatting of `<ul>` in `Reddit.com` comments. HOT 1
- Doesn't work on large pages. HOT 1
- Add context menu item to clear highlight HOT 1
- Can we get updates as per TPW's methodology if not via the Chrome Web Store? HOT 1
- Selection Error -- 'Couldn't create a unique link, please select a longer sequence of words' HOT 1
- Provide a method for generating a method from a range instead of a selection HOT 2
- Unable to link to text inside table HOT 2
- Incompatible encoding (`-`, `&`, `,`) HOT 1
- [feature-request] add to mobile/android HOT 4
- Doesn't work for Safari Version 16.6 (18615.3.12.11.2) HOT 1
- Do not remove pre-existent `#.*:` section of URI. HOT 3
- Copied Link to Selected Text Appearing as a Link Rather Than the Text HOT 1
- Text fragment link converts upper-case to lower-case in Firefox HOT 1
- Does not work on Firefox anymore HOT 6
- Always timeouts on certain websites HOT 1
- Does not work on the United Nations Code for Trade and Transport Locations location list. HOT 2
- Doesn't work on `https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry`. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from link-to-text-fragment.