Comments (4)
👍
from appengine-pipelines.
I agree. I think that we should just remove simplejson from pipeline library (version 2.1.1), it is included in requirement.txt in the correct version (the same as in mapreduce library). At the moment pipeline is broken because of old simplejson, even the tests are broken:
======================================================================
ERROR: testE2e (test.util_test.JsonSerializationTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/eshlox/projects/appengine-pipelines/appengine-pipelines/python/test/util_test.py", line 25, in testE2e
obj, cls=util.JsonEncoder), cls=util.JsonDecoder)
File "/home/eshlox/projects/appengine-pipelines/appengine-pipelines/python/src/pipeline/simplejson/__init__.py", line 269, in dumps
use_decimal=use_decimal, **kw).encode(obj)
File "/home/eshlox/projects/appengine-pipelines/appengine-pipelines/python/src/pipeline/simplejson/encoder.py", line 216, in encode
chunks = self.iterencode(o, _one_shot=True)
File "/home/eshlox/projects/appengine-pipelines/appengine-pipelines/python/src/pipeline/simplejson/encoder.py", line 277, in iterencode
self.skipkeys, self.allow_nan, key_memo, self.use_decimal)
TypeError: Required argument 'namedtuple_as_object' (pos 12) not found
After removing simplejson:
----------------------------------------------------------------------
Ran 3 tests in 0.006s
OK
Tests in my application also passed with this.
Here is the pull request: #11
from appengine-pipelines.
Is there a reason why it isn't:
try:
import json as simplejson
except:
import simplejson
?
For those of us that use the python27 runtime, we can benefit from the speedups afforded by the stdlib json import that has compiled c speedups and remove a dependency.
from appengine-pipelines.
Someone1: Good Point. Can you send a merge request?
Is there any other reason to keep this open?
from appengine-pipelines.
Related Issues (20)
- [Python][Bug] Yielded pipeline does not run on the specified task queue. HOT 3
- Files API Still Being Used in the demo app HOT 2
- In notify_barriers when queue task_retry_limit exceeded the pipeline never finalize HOT 5
- TaskQueue behavior for duplicate tasks in a list during Queue.add() HOT 3
- App Engine Pipeline not aborting all the way to root HOT 3
- Move pipeline URL from '/_ah/pipeline' to something else HOT 1
- ModulesService#getVersionHostname causes pipelines to fail often HOT 1
- Bumb pypi version? HOT 5
- Target param ignored during retry attempts and barrier notifications. HOT 4
- waitFor doesn't support FutureList HOT 2
- [JAVA] Cannot find the slot: pipeline-slot("56da1731-d616-4c7c-98e3-d21fe9e386b0"). Ignoring the task.
- GAE/GCE "python" runtime support? HOT 1
- exception during /_ah/pipeline/output: ancestor argument should match namespace ("'101970'" != "'102550'") HOT 1
- Sources for 0.2.13
- Use of im_func.
- Starting a task on a local module without an explicit version fails HOT 2
- cloud sdk 123 causes PipelineSetupError in dev server HOT 4
- _fix_path prevents module from importing if PYTHONPATH is not set
- Java: configure PipelineServlet to use a different (datastore) namespace
- Python: Bad target when running in development environments
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from appengine-pipelines.