Giter Site home page Giter Site logo

Comments (4)

webmaven avatar webmaven commented on June 28, 2024

👍

from appengine-pipelines.

eshlox avatar eshlox commented on June 28, 2024

I agree. I think that we should just remove simplejson from pipeline library (version 2.1.1), it is included in requirement.txt in the correct version (the same as in mapreduce library). At the moment pipeline is broken because of old simplejson, even the tests are broken:

======================================================================
ERROR: testE2e (test.util_test.JsonSerializationTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/eshlox/projects/appengine-pipelines/appengine-pipelines/python/test/util_test.py", line 25, in testE2e
    obj, cls=util.JsonEncoder), cls=util.JsonDecoder)
  File "/home/eshlox/projects/appengine-pipelines/appengine-pipelines/python/src/pipeline/simplejson/__init__.py", line 269, in dumps
    use_decimal=use_decimal, **kw).encode(obj)
  File "/home/eshlox/projects/appengine-pipelines/appengine-pipelines/python/src/pipeline/simplejson/encoder.py", line 216, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "/home/eshlox/projects/appengine-pipelines/appengine-pipelines/python/src/pipeline/simplejson/encoder.py", line 277, in iterencode
    self.skipkeys, self.allow_nan, key_memo, self.use_decimal)
TypeError: Required argument 'namedtuple_as_object' (pos 12) not found

After removing simplejson:

----------------------------------------------------------------------
Ran 3 tests in 0.006s

OK

Tests in my application also passed with this.

Here is the pull request: #11

from appengine-pipelines.

someone1 avatar someone1 commented on June 28, 2024

Is there a reason why it isn't:

try:
  import json as simplejson
except:
  import simplejson

?

For those of us that use the python27 runtime, we can benefit from the speedups afforded by the stdlib json import that has compiled c speedups and remove a dependency.

from appengine-pipelines.

tkaitchuck avatar tkaitchuck commented on June 28, 2024

Someone1: Good Point. Can you send a merge request?
Is there any other reason to keep this open?

from appengine-pipelines.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.