Cloud functions creation failed due to npm ci command

[onkarcraft]

Cloud functions creation failed due to npm ci command

[mservidio]

Are you able to try and run it from Cloud Shell?

[malan-craft]

Hey, thanks for the quick turnaround. In case you want how this error comes up in CircleCI:

Error: Error waiting for Creating CloudFunctions Function: Error code 3, message: Build failed: npm ERR! The npm ci command can only install with an existing package-lock.json or
npm ERR! npm-shrinkwrap.json with lockfileVersion >= 1. Run an install with npm@5 or
npm ERR! later to generate a package-lock.json file, then try again.

npm ERR! A complete log of this run can be found in:
npm ERR!     /www-data-home/.npm/_logs/2022-06-08T10_34_15_250Z-debug-0.log; Error ID: beaf8772

  on ../../modules/ingestion-function/cloud-functions.tf line 60, in resource "google_cloudfunctions_function" "datashare_cloud_function":
  60: resource "google_cloudfunctions_function" "datashare_cloud_function" {

We were able to do it via local terminal(place zip and run npm ci) and we can try via cloud shell.

But npm ci command is not part of repo and I believe this error is originating from the datashare_cloud_function resource block. If we run this command manually - we will still face issue when terraform tries to create this cloud function resource. How do we go about this?

We would also like to know is there a way to view the npm log? we could only see the mention of this log location in cloud logs

We are not sure if running this via cloud shell will help us in the long run as we would like this to be automated as much as possible.

[mservidio]

It may have partially deployed with an error. If you look in the GCP console at the Cloud Functions do you see the function created in error? If so, check the log for errors.

[malan-craft]

I can see the cloud function saying 'Function failed to deploy', the logs show the same error thrown out by terraform

Build failed: npm ERR! The npm ci` command can only install with an existing package-lock.json or
npm ERR! npm-shrinkwrap.json with lockfileVersion >= 1. Run an install with npm@5 or
npm ERR! later to generate a package-lock.json file, then try again.

npm ERR! A complete log of this run can be found in:
npm ERR! /www-data-home/.npm/_logs/2022-06-08T10_34_15_250Z-debug-0.log; Error ID: beaf8772`

How do we know if there is a partial deployment happened?

[mservidio]

Check on the cloud functions console page: https://console.cloud.google.com/functions/list

[malan-craft]

Yep, I checked here previously and I can see it says 'Function failed to deploy'. The error from the logs is added in above comment - Now that we know there is a partial deployment happening due to NPM error, how do we handle the cloud function creation/deployment via terraform?

[mservidio]

For now, you can comment out the resource for the cloud function creation in cloud-functions.tf. I'm not sure what your full requirements are and if you'll need it. Let's see if there are any subsequent issues beyond the cloud function creation within the environment. Is this for marketplace integration?

resource "google_cloudfunctions_function" "datashare_cloud_function"

[malan-craft]

Yes, this is for marketplace integration. Disabling cloud-function creation doesn't affect this marketplace integration? We are also planning to use data present in BigQuery table instead of GCS buckets - in that case is it safe to ignore ingestion folder and its content?

[onkarcraft]

We were able to complete the terraform steps after commenting out "datashare_cloud_function" but we don't see any datashare instance on GCP account. We completed the steps mentioned in INSTALLING.md this file except for the domain verification. What's the sequence of steps we need to do? There are numerous md files and each has few steps.

[mservidio]

Yes, the marketplace integration doesn't require the cloud function. As for the rest of the setup, I think it will be best to have a technical session. I'll have someone reach out offline.