Comments (6)
Because it causes problems with go modules. Why is it needed? You can always go mod vendor
before deploy if you need the files locally.
from govanityurls.
Why should the project remove vendor?
from govanityurls.
What problems does it cause for you specifically?
I like the vendor because it enables builds with contacting the internet.
from govanityurls.
I forked this repo and rewrote half the stuff in it a while back. That included removing the vendor folder. This doesn't cause me problems, but with other repos this makes upgrading vendors difficult. Like using yaml.v3 instead of yaml.v2. It's bad practice for public repos.
How do you build the data in this repo without connecting to the Internet to clone it? And if you can clone this repo, can't you clone the two vendor dependencies at the same time?
from govanityurls.
I appreciate that you don't like the vendor directory but you also haven't presented specific problems it is causing.
- Why is it bad practice on public repos?
- Why is upgrading vendors difficult? What specific commands are difficult?
from govanityurls.
Oh I like the vendor director. When I make it. ;) I have no dogs in this fight, so I'll let OP answer your questions.
from govanityurls.
Related Issues (12)
- path is not correctly redirected to the sub package
- please set cache headers HOT 2
- Allow Git paths to specify a default branch HOT 1
- Prefix wildcard matching is required HOT 1
- [Action Required] Upgrade your App Engine Standard applications to Go 1.11 or 1.12 before October 1, 2019 HOT 8
- migrate from godoc.org to pkg.go.dev HOT 2
- use PORT environment variable HOT 2
- http (non-https) urls still redirecting to godoc.org HOT 2
- [feature] regex/wildcard match in vanity.yaml
- module required error when get module in multi module repo mode HOT 2
- pages are not rendered with custom domain on app engine HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from govanityurls.