Ubuntu image tests failures

[googlecloudplatform]

Ubuntu image tests failures

[a-crate]

Thanks for the feedback Chlo! This is a great way to identify our deficiencies in the Ubuntu environment.

• verifySSHConfig()

Right now we are simply reading the config file, discarding the comments, and parsing what's left. This whole approach is clearly brittle and I think it would also break if you put two spaces instead of one on that line. I'll implement a more robust approach where we check the effective configuration.

• TestHostsFile()

This is supposed to be skipped on Ubuntu. Right now we skip the test if the image name contains ubuntu, can you share the images this isn't being skipped on?

• TestArePackagesLegal()

I'll take a look at updating these, at a glance they should be covered by the existing regexps but obviously there's some mistaken assumptions here.

• TestGetentPasswdOsloginUser() and TestGetentPasswdOsloginUID()

The oslogin suite requires some pretty specialized setup involving service accounts and org policies. I'm under the impression that it needs org-level setup to run the test correctly.* I'd suggest that you should continue to filter this suite out and if you want to create a separate org and run this suite we can get setup instructions for this. In the meantime I'll update the documentation to clarify this.

• testShutdownScriptTimeLinux()

Can you share the hash of the docker image you are getting this from? I think this is a bug, 89 seconds should be passing, anything over 80 is acceptable.

*I was wrong about this, setup is a bit simpler than that. Instructions are in the OSLogin suite readme

[a-crate]

#975 has updated some documentation, including setup instructions for oslogin in imagetest/test_suites/oslogin/README.md

[a-crate]

#980 should address verifySSHConfig()
#982 should address TestArePackagesLegal()

[kajiya3141]

Thanks @a-crate for the feedback and the PRs! 😄 Between those and the increased docs our pipelines are running much smoother - I'll close this now. Thanks again!