Comments (9)
Thanks for catching this! I'll get a fix out right away. Do you mind sharing how you are using the Open API spec or the various outputs that lead you to this bug? Thanks again!
from openapi-specification.
Ran it against https://github.com/ferdikoomen/openapi-typescript-codegen
it tried to do region = 'en'
but 'en'
was an invalid input
from openapi-specification.
Got it. Any other issues with codegen? I'm looking to eventually generate and publish some libraries from this.
from openapi-specification.
But.... I actually had to fix a bug in the repo, since their version couldn't handle the ~1
for path argument in references... so see ferdikoomen/openapi-typescript-codegen#824 for my hack/fix
from openapi-specification.
I could add a dereferenced (resolve all $ref) spec if that seems to be an issue with codegens.
from openapi-specification.
🎉 This issue has been resolved in version 1.16.20 🎉
The release is available on:
v1.16.20
- GitHub release
Your semantic-release bot 📦🚀
from openapi-specification.
Could do. I personally think the codegens should be able to deal with the spec correctly.. I've found others which can..
The only issue is that the naming of the endpoints were really bad.. Like.. REALLY bad.. after it got spit out of the codegen.
End endpoints ended up being like
getPlacesApiService()
getPlacesApiService1()
getPlacesApiService2()
getPlacesApiService3()
getPlacesApiService4()
instead of something useful like
getPlacesTextSearch()
getPlacesDetails()
etc etc
I am unsure if that is an issue with the openapi-typescript-codegen
or the spec file though. I would have to check that particular issue with other tools and see what they spit out..
Since you correctly tagged similar apis such as places/roads/streetview
.. I would presume you are doing things right.
I know it handles our own api correctly, but I have not done a side by side to know 'how' these codegens decide the names of the functions
from openapi-specification.
Seems I could improve that with operationId
although the fallback in the could also be improved. https://github.com/ferdikoomen/openapi-typescript-codegen/blob/830b317d0a0f6aaa97dba43818ce6d1ccc109be2/src/openApi/v3/parser/getOperation.ts#L22-L23
from openapi-specification.
It would seem you hit it perfectly..
our API has "operationId": "Card_CardAccessAdvisorByRole",
and the function does seem to indicate this is what it would output if you remove non alphanumerics and run a run camelcase on it would result in cardCardAccessAdvisorByUser
and that is exactly what we get.
the cardCard
in our codebase is a little undesirable, but nothing to cry too much about...
Good spot with getOperation
from openapi-specification.
Related Issues (20)
- Distance is not returning miles even if units=imperial HOT 1
- Unable to search with text in Google reviews HOT 2
- Is there a way to filter the google reviews based on the name mentioned on the reviews , with Google Maps Details API? HOT 2
- Generated docs for nearest roads "points" parameter uses "points" and "path". Should be points. HOT 2
- Test action failing during Bazel build
- [schemas] PlacesApi PlaceAutocompleteStructuredFormat HOT 1
- titles disappeared on html documentation HOT 2
- PlacesAPI: TextSearch region and radius parameters are not working HOT 2
- Place Api: There is error when using placeId query place and there is no postalCode,please! HOT 3
- [schemas] Bug - PlacesDetailsResponse HOT 1
- [schemas] Bug - PlacesDetailsResponse HOT 1
- Places FindPlace Bug - Field "url" HOT 1
- Is the use of $ref compliant with OpenAPI 3.0.3 specification? HOT 2
- [parameters] Bug - /maps/api/place/autocomplete/json HOT 1
- [parameters] Bug - /maps/api/place/details/json HOT 1
- [parameters] Bug - mode=transit - /maps/api/distancematrix/json & /maps/api/directions/json
- [Place Details API response] geometry field - LatLngLiteral does not specify the geocode level HOT 1
- Endpoint query parameters omit key HOT 1
- Roads: snapToRoads has incorrect URL in spec HOT 1
- Missing openapi specification file for "New Places API" HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openapi-specification.