Comments (9)
App should specify the API version you want to use meaningly and library should not be set it automatically, I think. Otherwise App might behave the developer did not intend. (For now the API returns the deprecated error, but you can use it.)
from foursquare-ios-api.
You're correct that the Foursquare API currently returns a deprecated error along with an actual response; however, the response defaults to the oldest version of the API, meaning users that don't bother passing in a v
param are missing out on some modern features, but more importantly, the API will soon stop supporting API requests that don't pass a v
param.
If you're rather discuss this off of GitHub issues, feel free to reach out to [email protected]. We're making this change in the future and wanted to give adequate time for library owners to transition.
from foursquare-ios-api.
I see. Which value is appropriate if a v param is missing? Current date?
from foursquare-ios-api.
20131023
is certainly a possibility, but it shouldn't be dynamically be set to always be the "current" date (e.g., if a breaking JSON change happens tomorrow and your library always has the current date set, you could run into parse errors). Pick a date (strongly recommend after 20120609
) as the minimum supported version of your library and stick to that as the default, allowing your users to override if they wish.
from foursquare-ios-api.
We've released 1.1.6. "20120609" as the default value has been added. Please confirm the change.
from foursquare-ios-api.
LGTM, so long as the library still pass your tests.
I would still strongly recommend at some point moving to a more modern version though. You could be missing out on some newer features of the API. (For example, compare a venues/explore request with 20120609 vs 20131024. The new "snippets" justification block was added since last June!)
from foursquare-ios-api.
I think you need 20120610 at least. I was getting request failures with a response from Foursquare saying that 20120609 is no longer supported.
$ Error getting foursquare checkins: Error Domain=BZFoursquareErrorDomain Code=410 "The operation couldn’t be completed. (BZFoursquareErrorDomain error 410.)" UserInfo=0x16d2f580 {errorDetail=The Foursquare API no longer supports requests that pass in a version v <= 20120609. For more details see https://developer.foursquare.com/overview/versioning, code=410, errorType=param_error}
from foursquare-ios-api.
As noted last year, the recommendation was to make the date after 20120609
, which we have since deprecated.
from foursquare-ios-api.
Right, but the default in this library is still this: https://github.com/baztokyo/foursquare-ios-api/blob/master/BZFoursquare/BZFoursquare.m#L37 So shouldn't this be updated to at least 20120610?
from foursquare-ios-api.
Related Issues (13)
- Potential issue with different callback URL's HOT 2
- getting 500 Internel Server Error all the time HOT 1
- Problems calling the delegate methods HOT 1
- URL callback issue HOT 1
- How to get Photo details HOT 1
- Incorporate Foursquare native auth HOT 4
- Documentation: MobileCoreServices Framework needs to be added to Linked Binaries HOT 1
- Implicit conversion of a non-Objective-C HOT 1
- Create cocoapods.org pod
- Question: Xcode User-Defined Build Settings HOT 6
- Missing header file "BZSynthesizeSingleton.h" HOT 3
- userless requests HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from foursquare-ios-api.