Superfluous call of utils/prepare_lang.sh in kaldi-run-chain.sh?

[gooofy]

Superfluous call of utils/prepare_lang.sh in kaldi-run-chain.sh?

[gooofy]

you're probably right for use cases that first build the lm and then run the training script once - which is certainly the most common case.

however, I am a bit torn about removing that line from the training script - there might be use cases where it is useful for the training script to be (somewhat) self-contained, i.e. re-create data/lang.

what is you main concern here - runtime (does take prepare_lang.sh a significant amount of time compared to the runtime of the whole script) or clarity of the code?

[mpuels]

My main concern is "Why do a job twice?" :) But it would be ok for me, if prepare_lang.sh would stay in both scripts - I understand your concerns.

[gooofy]

ok - then I would vote for leaving it in, for now. if it gets in the way at any point, do not hesitate to remove it from one of the scripts :)

closing the issue, for now.