Comments (5)
hey @tomfa ,
Which npm are you on?
https://github.com/gor181/react-notification-system-redux/blob/master/package.json#L28-L33 are the dependencies.
How did you measure the size?
Cheers
from react-notification-system-redux.
I measured the size by using webpack, and by adding and removing
import Notifications from 'react-notification-system-redux';
from my source files (not using it).
It seems to me it was the usage of lodash that was the cause of almost all of the size increase (1.37 of 1.45 MB). (Tested by replacing the import with import {each, extend} from 'lodash';
npm was on version 3.9.2. Upgrading to 3.10.5 did not help.
from react-notification-system-redux.
E.g. I guess this is not your fault? I'll figure out where I've gone wrong :)
Thanks for the library, btw! 👍
Edit: Could replace lodash with ES6 for the next version? (I presume there's not many people using ES5 with Redux)
from react-notification-system-redux.
Yeh we can get rid of lodash, usage of 2 common simple functions is defeating the purpose of having the whole lib as dep.
thanks @tomfa
from react-notification-system-redux.
hey @tomfa
Could be a bit better now. Lodash is only required in dev mode due to examples and the redux being there.
from react-notification-system-redux.
Related Issues (20)
- Does it working with IE11? HOT 1
- Ability to limit the max # of notifications displayed in the UI? HOT 1
- is `allowHTML` supported? HOT 2
- Can I re-render a notification? HOT 1
- [question] Showing notifications makes browser to scroll up
- different styling when using multiple components
- [suggestions] improve docs and info
- react-redux v6.x support HOT 4
- context.store undefined (React 16 + Redux 4) HOT 1
- Feature request: Remove notifications by level
- Uncaught TypeError: Cannot read property 'dispatch' of undefined HOT 6
- TypeError: Cannot read property 'map' of null
- Update Peer Dependencies to support react-redux v7.x HOT 4
- react-notification-system Warning with React 16.0.9 HOT 1
- Hooks api HOT 1
- update peer dependency for react-notification-system HOT 1
- why is there a react version restriction HOT 2
- Update to be used along with react 18 HOT 1
- Come here if you want to make it work with react 17 or 18
- onRemove should pass in notification
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-notification-system-redux.