Giter Site home page Giter Site logo

Comments (5)

gor181 avatar gor181 commented on September 12, 2024

hey @tomfa ,

Which npm are you on?

https://github.com/gor181/react-notification-system-redux/blob/master/package.json#L28-L33 are the dependencies.

How did you measure the size?

Cheers

from react-notification-system-redux.

tomfa avatar tomfa commented on September 12, 2024

I measured the size by using webpack, and by adding and removing
import Notifications from 'react-notification-system-redux'; from my source files (not using it).

It seems to me it was the usage of lodash that was the cause of almost all of the size increase (1.37 of 1.45 MB). (Tested by replacing the import with import {each, extend} from 'lodash';

npm was on version 3.9.2. Upgrading to 3.10.5 did not help.

from react-notification-system-redux.

tomfa avatar tomfa commented on September 12, 2024

E.g. I guess this is not your fault? I'll figure out where I've gone wrong :)
Thanks for the library, btw! 👍

Edit: Could replace lodash with ES6 for the next version? (I presume there's not many people using ES5 with Redux)

from react-notification-system-redux.

gor181 avatar gor181 commented on September 12, 2024

Yeh we can get rid of lodash, usage of 2 common simple functions is defeating the purpose of having the whole lib as dep.

thanks @tomfa

from react-notification-system-redux.

gor181 avatar gor181 commented on September 12, 2024

hey @tomfa

Could be a bit better now. Lodash is only required in dev mode due to examples and the redux being there.

from react-notification-system-redux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.