Giter Site home page Giter Site logo

Draft of new server.go about raft HOT 3 CLOSED

goraft avatar goraft commented on September 28, 2024
Draft of new server.go

from raft.

Comments (3)

benbjohnson avatar benbjohnson commented on September 28, 2024

@xiangli-cmu That's basically what I was thinking too. Looks good. Just a couple notes:

  1. Do we need separate goroutines for sendAndCollectVotes and commitCenter? It seems like those could be combined into the candidate and leader functions without spawning off something asynchronous.
  2. Can you rename the functions to be verbs? e.g. follower() -> follow(), candidate() -> promote(), leader() -> lead()?
  3. Change the constants to be initial-case: LEADER -> Leader. Go doesn't typically use all-caps.

from raft.

xiang90 avatar xiang90 commented on September 28, 2024

For 1, probably we can do them in one select.

For 2 and 3, I will do it when I am going to write the codes.

What do you think about this structure?

from raft.

benbjohnson avatar benbjohnson commented on September 28, 2024

@xiangli-cmu I think the structure looks great. Go for it.

from raft.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.