EventEmitter threads never terminate

[kreichgauer]

EventEmitter threads never terminate

[kreichgauer]

Ah, the loop can be stopped by calling watchdog_fsevents_stop. But this is done in FSEventsEmitter.on_thread_exit while it should really be done in FSEventsEmitter.on_thread_told_to_stop.

Fix kreichgauer/watchdog@9dfdebf

[kreichgauer]

Kind of related: Shouldn't the BaseObserver thread join on an EventEmitter thread, whenever it stops and removes one? I.e. whenever someone calls BaseObserver.unschedule or BaseObserver.unschedule_all. I occasionally see an instance of #43, basically because a test case calls unschedule_all on an observer and then goes on to delete the observed directory, while the FSEventsEmitter thread is still running. This wouldn't happen if unschedule_all waited for the emitter to exit.

[kreichgauer]

Applied the fix in 2a75987.

[kreichgauer]

Just saw that the same issue exists in InotifyEmitter and probably KqueueEmitter too. Reopening.

[tamland]

there have been many fixes to the thread handling since. should be fixed