Unit tests

[gordon-cs]

Unit tests

[superpowers11]

The naming convention I opted for was MethodBeingTested_Input_ExpectedBehavior. (E.g. IsValidUser_InvalidPassword_ReturnFalse)
It seemed the most concise, informative option.
If you all have different preferences, I am open to them, but I figure we should be consistent across all unit tests.

[superpowers11]

I'm finished 7 tests, but I tried to leave some options for you guys as well since we all have to write 5-10 for Monday.

• GetRoom in LoginService may need more tests
• GetBuilding in LoginService still needs all tests
• GetRoom in LoginService still needs all tests
• ToUnixTime is sort of a random utility, that could be tested if we want, but seems kind of unnecessary
• Once we have segmented HomeController's body code into a service, it will be easier to unit test as well

[eanyanwu]

Thanks steph! I'll try to write some exhaustive unit tests today then.

[eanyanwu]

I have written about seven unit tests as well....six of which fail...i mean succeed? I haven't made them pass yet, as I think we can do that in another branch. That is just to keep all the changes in the Unit-test branch limited to Phoenix.Tests.