Comments (6)
I'll start thinking about this and post what I think here. Anyone else doing this issue should do the same so we can compare notes.
from project-phoenix.
I was able to verify this for myself (based on my old room in Ferrin), but I can't verify yet for apartments. I think we need to add multiple test accounts to RoomAssign in order to test all the different cases:
- When first apartment member logs on - should generate both an individual RCI and common area RCI
- When all succeeding apartment members log on - should generate only an individual RCI, but should display the already existing common area RCI.
- When someone lives in a Ferrin apt, room code is of the form "L05" - so I need to verify this check is working correctly.
from project-phoenix.
Hmmm RCI's for Ferrin apartments are a little different. In the Room
table, there are not multiple entries per apartment, as was the case for Bromley and Tavilla. An apartment is simply listed as L05, with a MAX_CAPACITY of 3.
So, in RCI
table, should we just have 3 entries for a given RoomCode?
For example, for the apartment 'L05', we'd have the following in the RCI
table:
- Common area GordonID = null, RoomCode = 'L05'
- Resident1 GordonID=Resident1ID, RoomCode = 'L05'
- Resident2 GordonID=Resident2ID, RoomCode = 'L05'
from project-phoenix.
Good catch. That seems fine by me.
Isn't that how the rbi table is already set up?
It doesn't seem we are adding the A's and B's to Bromely or Tavilla apartments either.
Two things I observed by looking at your branch:
- Your code currently trims the 'L' from the begining. I don't think we should.
- The variable
strBuilding
should be trimmed before doing this comparisonwhere tempCommonAreaRCI.RoomNumber == strRoomNumber
from project-phoenix.
@eanyanwu so you think we should do like I said in the comment above and just have all three RCI's for a Ferrin apartment (common area + 2 resident RCI's) have the same number, e.g. L05?
I'm not sure what you mean by the second bullet point. Could you do an inline comment in the code you're referring to?
from project-phoenix.
Resolved with #34
from project-phoenix.
Related Issues (20)
- Figure out bathrooms for suites HOT 5
- Add "Other" Component
- Bind images and text descriptions HOT 5
- Differentiate fines/charges HOT 8
- Accurately reflect RA vs. AC HOT 1
- Move furniture around from within the input view. HOT 2
- Legal wording HOT 4
- DateTime is misleading HOT 2
- User Error Responses HOT 3
- Add cost column to RciComponent Table HOT 1
- RD and Admin functionality documentation HOT 2
- Add logging abilities HOT 6
- Admin perspective on various signatures HOT 1
- Common Area Generation Problem HOT 2
- Top logo spaced oddly in IE HOT 1
- Issues encountered during first release HOT 3
- Bug Dump
- Update Readme to reflect recent changes
- Issues encountered during the second checkin HOT 2
- Figure out who updates the RoomAssign Table and how they do so
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from project-phoenix.