Giter Site home page Giter Site logo

Comments (6)

eanyanwu avatar eanyanwu commented on July 20, 2024

I'll start thinking about this and post what I think here. Anyone else doing this issue should do the same so we can compare notes.

from project-phoenix.

superpowers11 avatar superpowers11 commented on July 20, 2024

I was able to verify this for myself (based on my old room in Ferrin), but I can't verify yet for apartments. I think we need to add multiple test accounts to RoomAssign in order to test all the different cases:

  • When first apartment member logs on - should generate both an individual RCI and common area RCI
  • When all succeeding apartment members log on - should generate only an individual RCI, but should display the already existing common area RCI.
  • When someone lives in a Ferrin apt, room code is of the form "L05" - so I need to verify this check is working correctly.

from project-phoenix.

superpowers11 avatar superpowers11 commented on July 20, 2024

Hmmm RCI's for Ferrin apartments are a little different. In the Room table, there are not multiple entries per apartment, as was the case for Bromley and Tavilla. An apartment is simply listed as L05, with a MAX_CAPACITY of 3.
So, in RCI table, should we just have 3 entries for a given RoomCode?


For example, for the apartment 'L05', we'd have the following in the RCI table:

  1. Common area GordonID = null, RoomCode = 'L05'
  2. Resident1 GordonID=Resident1ID, RoomCode = 'L05'
  3. Resident2 GordonID=Resident2ID, RoomCode = 'L05'

from project-phoenix.

eanyanwu avatar eanyanwu commented on July 20, 2024

Good catch. That seems fine by me.
Isn't that how the rbi table is already set up?
It doesn't seem we are adding the A's and B's to Bromely or Tavilla apartments either.

Two things I observed by looking at your branch:

  • Your code currently trims the 'L' from the begining. I don't think we should.
  • The variable strBuilding should be trimmed before doing this comparison where tempCommonAreaRCI.RoomNumber == strRoomNumber

from project-phoenix.

superpowers11 avatar superpowers11 commented on July 20, 2024

@eanyanwu so you think we should do like I said in the comment above and just have all three RCI's for a Ferrin apartment (common area + 2 resident RCI's) have the same number, e.g. L05?
I'm not sure what you mean by the second bullet point. Could you do an inline comment in the code you're referring to?

from project-phoenix.

superpowers11 avatar superpowers11 commented on July 20, 2024

Resolved with #34

from project-phoenix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.