Electronic Signature on Check-in - Resident, RA, and RD

[gordon-cs]

Electronic Signature on Check-in - Resident, RA, and RD

[fallcat]

Advanced electronic signature (maybe we don't need this advance):

• The signatory can be uniquely identified and linked to the signature
• The signatory must have sole control of the private key that was used to create the electronic signature
• The signature must be capable of identifying if its accompanying data has been tampered with after the message was signed
• In the event that the accompanying data has been changed, the signature must be invalidated

[fallcat]

• Will add bit columns "CheckinSigRes" "CheckinSigRA" "CheckinSigRD"

[eanyanwu]

Yea we don't need it to be that advanced. I think that is talking about hash signatures e.g. Cryptographical signing?
The columns will be added to the RCI table right?

[fallcat]

Yes. I have just added them.

[fallcat]

#44

[superpowers11]

RA still needs to be able to sign both as RA and resident.

[superpowers11]

I just remembered, we need to add a checkbox or something that allows an RD to sign for all the RCI's at once, correct? And maybe we want this for checkout too, @eanyanwu ? So should we add that to issue 36 as well?

[fallcat]

Yes I think we should add that.

[fallcat]

Another problem, should we add the ID of the person who signed to the table as well? Right now, if RA A signs at Resident B's RCI Checkin, and then RA C views the signature, RA C will see the signature of C instead of A...

[superpowers11]

So you mean, if a different RA from the resident's building looks at the RCI, it will show the incorrect signature name? Hmmm... yes, maybe it would make sense to add the ID to the sig. Or could we just not display which RA signed it, but rather simply show a message saying "This RCI has been signed by the RA"

[fallcat]

True... but it will disregard some existing functionality in current paper system

[superpowers11]

This is nearly done: we just need to figure out the bug of why AJAX calls are not being received by the server.
For now, we are going to just show that some RA has seen it, and some RD has seen it. In the future, we will add specification for which RA and which RD has signed.

[fallcat]

Also, change signature from username to name.

[eanyanwu]

This works fine for an RA whose resident has not yet signed. From briefly glancing over the code, we might be getting errors when we try to go to the signing page for a common area rci (no gordonID, the call to GetUsername won't work?). Since I don't have a resident account, @superpowers11 or @fallcat should test this hypothesis.

[superpowers11]

I am not sure if this is the source of the problem, but it looks like line 10 in checkin-sig-res.js is returning undefined. Would that keep the AJAX call from being completed?

---

@eanyanwu you make a good point. I just tried it for my "Tavilla apartment"'s common area, and I get an exception because GetUsername fails when there is no gordon_id.

[fallcat]

Oh you guys are right @superpowers11 @eanyanwu . I didn't think about the common area RCI problem.

[eanyanwu]

Also check out my comment on slack for another reason it might not be working

[eanyanwu]

Even more suggestions:
You post methods should return ActionResult so you can direct the user to the right page based on the validity of what they entered.
If they entered the right signature, then we can redirect them to the dashboard.
If they entered the wrong signature, we can redirect them to CheckinSig again.

[fallcat]

@eanyanwu Good point! I've made the change

[fallcat]

Closed by #83