Comments (7)
+1 :). In the meantime, check out https://github.com/hoodsy/3ree-auth-example which uses passport-based auth.
from 3ree.
@snobear is it just me, or is https://github.com/hoodsy/3ree-auth-example still rather immature? It seems to have issues with the server side rendering. @GordyD has done such a great job here, I shouldn't be comparing! :-)
from 3ree.
@tzarger yes, its still immature and I'm running into a few places in the code that are not built out yet, but its a decent starter reference if you're looking to add auth to this stack.
from 3ree.
Been meaning to comment on this for a while, but I've been going back and forth on whether this would be a suitable addition, apologies for the delay.
On the one hand I see that this would be practical as it would make the demo app more realistic in terms of how you would handle user auth in the real world. Potentially strengthening it as a boilerplate/foundation for 3ree apps.
On the other I see that this adds unnecessary, and opinionated, bloat to the project, where the overriding purpose is to enable people to get to grips with the minimal building blocks of a 3ree app.
Ultimately it comes down to what this repo is trying to be and what I have time for:
- more boilerplate/foundation for use when adopting the 3ree stack
- or more just a demo
I'd be happy with more boilerplate/foundation, but with that comes a great need for maintenance and documentation, and I'd probably need more community support. Would either of you be willing to contribute on some semi consistent level?
from 3ree.
What attracted me to this project initially was its simplicity, so I agree you should keep it as is. I've seen a few other awesome stacks out there, but they tend to get super bloated. I'd say build a totally separate 3ree app that illustrates best practices on authentication based on this base 3ree project. Sounds like its time for a 3ree micro framework :).
I would love to contribute to this project, but can't commit at the moment. I'm still learning the various pieces of the stack and how it all works best together and as the usual excuse, too busy at the moment.
from 3ree.
@GordyD @snobear Hello, thank you for your response ... Yes, I understand your point about keeping this repo simple etc. In regards to helping contribute, sure, I would love to perhaps spend some semi-consistent time contributing to perhaps a new repo that takes this current repo and builds upon it.
I should be able to contribute auth using JWT but may need some input on the RethinkDB change feed in order to best work out how perhaps send messages to specific users with change feeds. It might be nice to be able to assign tasks to specific users and only those users would see the tasks show up in "My Events" kind of thing, vs the "Other Events" list of items to make some items private vs unassigned would be "Other Events" for everyone. To me that would be a complete circle of real life use case that has very little coverage in other boilerplates.
Thoughts?
from 3ree.
@tzarger since this would be a sizable addition, I'd recommend you starting a separate project from this. I don't think @GordyD or myself would have the time currently to offer the proper advice, research and/or code review.
That said, I'm happy to offer any advice on your project. Just post a link to an issue to discuss in once you get it up and going. I implemented passport in my 3ree project. Its private though so can't share unfortunately :).
from 3ree.
Related Issues (20)
- Is Jade Necessary? HOT 4
- Sorry there is no Error
- Required prop `location` HOT 1
- Add Unit Tests HOT 1
- Add ESlint HOT 4
- not updating between multiple browsers HOT 1
- Upgrade to Babel 6 HOT 3
- Having a grandparent directory named 'src' causes bug HOT 2
- Move to react-router-redux HOT 10
- Error on npm start HOT 11
- rethinkdb not installed as global
- Misc HOT 3
- Unhandled rejection TypeError when loading page HOT 11
- Error running project on Windows HOT 3
- Slow loading on demo app HOT 3
- Warning: React attempted to reuse markup in a container but the checksum was invalid HOT 3
- Any plans to add auth? HOT 4
- Why not add PostCSS and Autoprefixer?
- Can't Install on Ubuntu 16.04.1 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 3ree.