Giter Site home page Giter Site logo

Filter about ublock HOT 26 CLOSED

gorhill avatar gorhill commented on May 10, 2024
Filter

from ublock.

Comments (26)

gorhill avatar gorhill commented on May 10, 2024

For 1., by design: you need to to add something to the filter so that uBlock can tell it's not a hostname -- since uBlock can also read hosts files. So if you enter just affiliate, uBlock doesn't know if it's a hostname, or a keyword to match at any position in a URL. So you found the proper solution, to use /affiliate instead.

For 2., I am going to say by design too: uBlock will match the first occurrence, whatever follow is of no importance, because it is the first occurrence which triggered the match, not the following ones. Ok, I didn't look properly what was going on.

from ublock.

my-password-is-password avatar my-password-is-password commented on May 10, 2024

It thinks the filter is regex because it starts with '/' and ends with '/'. So it matched 'ad'.

Using //ad/.*/ matches "/ad/*"... Do you really have to use it like this?

I tested //ad/.*/$important and it matched '/ad/'. The "$important" was used just for testing so uBlock uses my filter instead of another filter it was using to block it.

from ublock.

my-password-is-password avatar my-password-is-password commented on May 10, 2024

@gorhill

On that same page he provided

Try /adj/*$important , this just matches 'adj'

Then try //adj/.*/$important , this matches '/adj/......'

from ublock.

gorhill avatar gorhill commented on May 10, 2024

@my-password-is-password //adj/.*/ should matches /adj/ (aside the missing escaping of forward slashes). What am I missing?

from ublock.

my-password-is-password avatar my-password-is-password commented on May 10, 2024

In the request log the filter /adj/*$important just highlights 'adj'

//adj/.*/$important works fine, I know. Is the filter /adj/* suppose to highlight "/adj/.........." in the request log?

/adj/*$important
ublockorequestloghightlight

//adj/.*/$important
ublockorequestloghightlight2

Isn't /adj/*$important suppose to highlight the same as //adj/.*/$important

from ublock.

gorhill avatar gorhill commented on May 10, 2024

@my-password-is-password

Ok I see, you meant your request log, I kept trying to find what you were talking about in the posted screenshot in OP.

Yes, it is wrong. Looks like a rendering issue in the logger, as the match is the right one.

from ublock.

gorhill avatar gorhill commented on May 10, 2024

@my-password-is-password

Can you open a new issue for this please? I do not want to mix up everything. There were no issue in OP, so I want that part cleared. You found a very specific issue, I want it separate rather than piled on inside another issue. This allow me to accurately match code changes with very specific issues.

I thought this could be a quick fix but it is not despite appearing trivial. It is definitely a rendering issue (internal pattern matching works as expected), but it finds its root cause far from where the rendering is done in the dev log.

from ublock.

my-password-is-password avatar my-password-is-password commented on May 10, 2024

@gorhill

His issue is the same, I think. Look at his screenshot where ad is highlighted instead of '/ad/'. I just used the example '/adj/*' becuase nothing followed /ad/ to make it more visible to see in the request log.

from ublock.

gorhill avatar gorhill commented on May 10, 2024

@my-password-is-password

That's right, I see it now. Sorry about this.

from ublock.

my-password-is-password avatar my-password-is-password commented on May 10, 2024

@gorhill

Does ABP filter syntax consider '/ad/' as regex or is that just uBlock? To match just '/ad/' in uBLock you have to use '//ad//'? I don't know if it suppose to be like..

from ublock.

gorhill avatar gorhill commented on May 10, 2024

@my-password-is-password

It's just a rendering thing. Internally, the filter is really evaluated as /ad/*, i.e. not as a regex.

from ublock.

my-password-is-password avatar my-password-is-password commented on May 10, 2024

Oh ok. Thanks

from ublock.

polilla avatar polilla commented on May 10, 2024

Thanks for re-opening and investigation.
/ad/* or /ads/* are "/ad/" or "/ads/"
This is the syntax from Adblock Plus.

from ublock.

polilla avatar polilla commented on May 10, 2024

Ah, ok, gorhill said that this is only a rendering thing, because internaly this filter block how it must.

from ublock.

polilla avatar polilla commented on May 10, 2024

This is what i learned. When its starts with a Slash "/" and ended with a Slash "/" you must mark it with a "*".

from ublock.

lewisje avatar lewisje commented on May 10, 2024

yes, because if ABP or AdBlock or uBlock can recognize a blocking filter as a regex, it will

from ublock.

polilla avatar polilla commented on May 10, 2024

And i use this moment for say that uBlock is confused for the people.
Firefox AMO is now 0.9.1.0. You has Version 0.9.3.0 and more.
My Chromium-Browser under Linux updated from uBlock to uBlockO.
This is a totally chaos in my opinion.

from ublock.

polilla avatar polilla commented on May 10, 2024

I can understand Google. You put your uBlock with same code, same pictures, all is the same in Google. And now your are wondering why they kicked you?

from ublock.

polilla avatar polilla commented on May 10, 2024

All as is tu comunicate with the people befor you do anything. Not after.

from ublock.

harshanvn avatar harshanvn commented on May 10, 2024

@polilla Please try to stay on the topic.

Firefox AMO is now 0.9.1.0. You has Version 0.9.3.0 and more.

This is nothing a uBlock Dev can do. It is the AMO process too slow.

I can understand Google. You put your uBlock with same code, same pictures, all is the same in Google. And now your are wondering why they kicked you?

there is thread reg. this. Don't mix up the other things here (#50)

from ublock.

polilla avatar polilla commented on May 10, 2024

Sorry you are right. But AMO-process is now completed since yesterday.

from ublock.

RandomAcronym avatar RandomAcronym commented on May 10, 2024

I can understand Google. You put your uBlock with same code, same pictures, all is the same in Google. And now your are wondering why they kicked you?

@polilla Google took the original uBlock off the CWS, not the one "put" up this month...

from ublock.

older7 avatar older7 commented on May 10, 2024

Sorry for the off-topic, Lithuanian news portal blocks viewers with adblockers from their videos http://www.lrytas.lt/ Maybe there is a the solution for this problem or what? Thank you.

from ublock.

lewisje avatar lewisje commented on May 10, 2024

For questions about issues with third-party lists (including "anti-adblock" because all it does is check whether certain stuff was loaded or hidden, websites can't directly detect ad-blocking extensions), go here, because we use the same filter lists that ABP does: https://adblockplus.org/forum/viewforum.php?f=2&sid=40a7bda4087df46e76988d185b384b7a

from ublock.

older7 avatar older7 commented on May 10, 2024

So far helps me solve problems reek/anti-adblock-killer filter.

from ublock.

lewisje avatar lewisje commented on May 10, 2024

Yes, that and the Adblock Warning Removal List should cover your bases well.

If you use Reek's filters, be sure to also install the associated UserScript, which makes sophisticated changes to certain anti-Adblock tools that filter-lists alone cannot: https://github.com/reek/anti-adblock-killer#step-3-userscript

from ublock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.