Comments (5)
Can you show me your code as well?
from handlers.
I agree with Krishna
Options requests should not be passed to next handler.
We should add condition like this
#71
from handlers.
@elithrar Sorry I had forgotten about this issue! using this package now, you can close the issue if you think the code is fine. Maybe there was some issue with my code. But if @dautushenka is also facing an issue you can look at it.
from handlers.
If you can address my comment in #71 we
can merge it :)
On Wed, Mar 23, 2016 at 10:13 AM Krishna Srinivas [email protected]
wrote:
@elithrar https://github.com/elithrar Sorry I had forgotten about this
issue! using this https://github.com/rs/cors package now, you can close
the issue if you think the code is fine. Maybe there was some issue with my
code. But if @dautushenka https://github.com/dautushenka is also facing
an issue you can look at it.—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#68 (comment)
from handlers.
Closed via #71 - thanks @dautushenka.
from handlers.
Related Issues (20)
- [Feature] Json logging handler HOT 2
- [feature] FileServer handler HOT 2
- [feature] add brotli encoding support in compress handler HOT 3
- [bug] ProxyHeaders breaks gorilla/csrf HOT 1
- [bug] websockets are logged with a status code of 200 instead of 101 HOT 1
- [bug] ProxyHeaders XFF parsing handles whitespace incorrectly
- [question] How to add X-Request-ID in access Log
- [question] Does handler add AllowedOrigins * header by default?
- [feature] Basic Auth handler
- [feature] improve the CPUUtilization and MemoryUtilization
- Incorrect regex in `forRegex`
- [question] upgrade httpsnoop HOT 1
- OPTIONS in Allow for MethodHandler
- The ProxyHeaders middleware is misleading and dangerous
- [BUG] CORS middleware sets `Vary: Origin` header only in some cases HOT 1
- [BUG] Listing Origin as an allowed request header is unnecessary
- [FEATURE] Allow users to disable caching of preflight responses
- [FEATURE] Support Private Network Access
- [BUG] Sometimes missing Vary: Origin header may lead to Web cache poisoning
- [BUG] Allowing methods that are not uppercase should be possible but isn't
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from handlers.