Use the exact URI specified by the application when writing the request URI to the network

[gorilla]

Use the exact URI specified by the application when writing the request URI to the network

[davecheney]

Hi Gary,

I've been thinking about this a bit. I don't like url.Parse, it is too lenient. My plan is to write a http specific url parser, but it will be strict, and will have to take one position on URI encoding.

Here is what I am thinking

http.Get(string) will always feed the uri string to this parser so it may not be possible to handle that sample url correctly at that level. I don't know, I have't written it, however

client.Do will take a uri, not a string (the current impl takes a path string and []string query, this is a hack)

if client.Get takes a string, or a uri is not certain at this point

[garyburd]

This is easy to get correct: Do not unescape the path when parsing the URL. Do not escape the path and query string when writing the path to the network.

If you plan to use the net/url URL type, then the parser should assign the raw path and query string to the URL Opaque field. Write the result of the URL RequestURI() method to the network. If the Opaque field is set, then RequestURI() returns the Opaque field as is. If an application constructed a URL by setting the Path and RawQuery fields instead of the Opaque field, then RequestURI() escapes the path and joins it with the query.

[davecheney]

Ok, that doesn't sound too hard. Could you give a list of URI's and I'll turn them into test cases.

On 07/08/2013, at 13:22, Gary Burd [email protected] wrote:

This is easy to get correct: Do not unescape the path when parsing the URL. Do not escape the path and query string when writing the path to the network.

If you plan to use the net/url URL type, then the parser should assign the raw path and query string to the URL Opaque field. Write the result of the URL RequestURI() method to the network. If the Opaque field is set, then RequestURI() returns the Opaque field as is. If an application constructed a URL by setting the Path and RawQuery fields instead of the Opaque field, then RequestURI() will escapes the path and joins it with the query.

—
Reply to this email directly or view it on GitHub.