Giter Site home page Giter Site logo

Comments (5)

jorgeegomez avatar jorgeegomez commented on July 20, 2024

@lauft Most of our holidays are of the type "First Monday after a-specific-date". I couldn't find in the code or other locales how to specify this.

from holidata.

lauft avatar lauft commented on July 20, 2024

@jorgeegomez The template looks more or less like this:

    def holiday_<holiday name in snake case>(self):
        """1. monday after <date>: [<flags>] <description>"""

        return [Holiday(
            self.locale,
            "",
            SmartDayArrow(self.year, <month>, <day>).shift_to_weekday('monday', order=1, reverse=False),
            "<description>",
            "<flags>"
        )]

See e.g.

def holiday_buss_und_bettag(self):

from holidata.

jorgeegomez avatar jorgeegomez commented on July 20, 2024

I just modified the pull request with the changes suggested in the review. I'll go through the checklist here:

  • All legal National holidays are listed ("business or work are suspended or reduced")
  • URL for the governing Law is included in the code, the relevant Law is "Ley 51 de 1983"
  • I could provide a translation. Not sure where it would go in the code.
  • I checked the spelling, and chose the names given by the previous contributor (not all holidays have a defined official name).
  • Fixed dates are correct, both religious-based and non-religious.
  • For variable date holidays, the algorithm seems right, and matches publicly available calendars like Google Calendar or Calendario de Colombia.
  • Easter-based holidays are based on Western Easter.
  • Source of government holidays is provided in the code.
  • Some holidays are moved to the first Monday after certain date.
  • No fixed-date holiday is moved in case it falls on Saturday or Sunday
  • I fixed one of the holidays, that had a missing religious flag
  • No new holidays or changes have been made since 2011

from holidata.

lauft avatar lauft commented on July 20, 2024

Perfect! 👍

The translation is only optional - it saves me the hassle to figure out what e.g. "Viernes Santo" or "Den slovanských věrozvěstů Cyrila a Metoděje" could mean. 😉

from holidata.

lauft avatar lauft commented on July 20, 2024

The data is available now. Thanks for your contribution!

from holidata.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.