Comments (5)
@lauft Most of our holidays are of the type "First Monday after a-specific-date". I couldn't find in the code or other locales how to specify this.
from holidata.
@jorgeegomez The template looks more or less like this:
def holiday_<holiday name in snake case>(self):
"""1. monday after <date>: [<flags>] <description>"""
return [Holiday(
self.locale,
"",
SmartDayArrow(self.year, <month>, <day>).shift_to_weekday('monday', order=1, reverse=False),
"<description>",
"<flags>"
)]
See e.g.
holidata/holidata/holidays/de-DE.py
Line 33 in 1db24d4
from holidata.
I just modified the pull request with the changes suggested in the review. I'll go through the checklist here:
- All legal National holidays are listed ("business or work are suspended or reduced")
- URL for the governing Law is included in the code, the relevant Law is "Ley 51 de 1983"
- I could provide a translation. Not sure where it would go in the code.
- I checked the spelling, and chose the names given by the previous contributor (not all holidays have a defined official name).
- Fixed dates are correct, both religious-based and non-religious.
- For variable date holidays, the algorithm seems right, and matches publicly available calendars like Google Calendar or Calendario de Colombia.
- Easter-based holidays are based on Western Easter.
- Source of government holidays is provided in the code.
- Some holidays are moved to the first Monday after certain date.
- No fixed-date holiday is moved in case it falls on Saturday or Sunday
- I fixed one of the holidays, that had a missing religious flag
- No new holidays or changes have been made since 2011
from holidata.
Perfect! 👍
The translation is only optional - it saves me the hassle to figure out what e.g. "Viernes Santo" or "Den slovanských věrozvěstů Cyrila a Metoděje" could mean. 😉
from holidata.
The data is available now. Thanks for your contribution!
from holidata.
Related Issues (20)
- Holidata.net domain expired? HOT 1
- Holidata.net seams down HOT 1
- Error in locale en-US, year 2024: Day after Thanksgiving HOT 1
- Add locale for es-PE HOT 1
- JsonEmitter returns invalid JSON object HOT 3
- Add locale for sl-SI HOT 1
- Add locale for en-AU HOT 2
- Error in locale fr-FR HOT 2
- Add locale for es-MX
- Add locale for en-india HOT 1
- Add locale for sl-SI HOT 4
- Add locale for en-ZA HOT 1
- Add support for locale en-AU HOT 1
- Error in locale en-GB, year 2022 HOT 1
- [Question] Module not installable from pypi? HOT 1
- Update legal sources for Turkish holidays HOT 1
- Locales for Scotland & Northern ireland HOT 1
- Removal of Columbus Day as an US Holiday
- Add locale for Hi-In (Hindi - India )
- Add locale for en-SG
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from holidata.