Comments (6)
@EricSimons i think we need to finalise the the v1 of the spec and tag it before we even think about extending it. This will help prevent a lot of confusion and mess with all the other developers given the number of codebase we have growing.
from realworld.
Excellent suggestion — we originally kicked the idea around of having oAuth as part of the core spec but decided against it to try and cut scope creep. oAuth implementations can vary between providers, frameworks, etc so broad support across all stacks would likely have been sufficiently difficult to create & maintain.
That said, I think a good solution to this might be encouraging folks to fork the existing repo's and add on additional functionality (in this case oAuth, but #26 would also benefit from something like this). We can still list them in the main readme, but they could (& should) be maintained as separate repos (unless we end up changing the core spec to include oAuth, image uploading, etc).
Would love to hear thoughts on this!
from realworld.
My 50 cents: social login is very common task for real life apps. Login with facebook, google, instagram at least.
Specs for my social apps are:
- signup with social network (after login with oAuth provider - create local profile for new user with specifiying additional detail like email or login into existing account if this token already attachet to any existing profile)
- login with social network
- link new social network to existing logged-in user
- (?) user profile merging if signed up via different oAuth providers (common problem for user when first time they signup with google, and next time - with facebook).
upd: related tasks:
- forget / reset password & email notifications,
- captcha on signup form
from realworld.
@EricSimons I'm guessing this isn't something we want to support in the core spec per the discussion in issue #90?
from realworld.
@Cameron-C-Chapman : imho, nope. Social login is complicated separate feature set.
One more idea: we can extend API spec via versioning, and add some "addons" to spec, like, social logins.
So, backend implementing this "addon" can use /v1-social/api" endpoint, not plain "/api". Next version of core spec can be "/v2/api". Maybe we can think on semver for spec.
from realworld.
@Cameron-C-Chapman yeah, social login would def fall into the "extra credit" category
@deksden I like the idea of potentially extending the spec via semver in the future 👍 probably will be a while before we create additional specs, but if/when we do, that seems like a great solution!
from realworld.
Related Issues (20)
- [Bug]: api & demo doesn't work HOT 2
- [SWAGGER] register and login response schema issue HOT 1
- [Bug]: Line breaks not showing correctly HOT 1
- [Bug]: Immediately signed out after logging in HOT 3
- [Backend] Remove Response Envelopes HOT 5
- [Bug]: When try to build HOT 5
- User registration success status code is 200, but docs/swagger show 201 HOT 1
- [Bug]: server ERROR 500 HOT 2
- [Bug]: CORS Error HOT 9
- [Feature Request]: offline functionality HOT 2
- [Bug]: Demo server status is 503 HOT 1
- [Feature Request]: Vuetify in Realworld example HOT 1
- [Bug]: Continuous modification of user information results in an error HOT 4
- Try this HOT 1
- [Bug]: demo APIs down? HOT 2
- [Bug] initialData.data from route loader is always undefined HOT 1
- API server doesn't work HOT 1
- [Bug]: Heroku Deployment failed
- [Bug]: API doesn't work HOT 4
- [Bug]:CORS Issue HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from realworld.