Giter Site home page Giter Site logo

Comments (11)

gotson avatar gotson commented on May 30, 2024 1

Thanks a lot for your effort in solving this! 🥳

I will give it a try after work.

Well it hasn't been released yet. Wait for the comment on that ticket once released.

from komga.

JerwuQu avatar JerwuQu commented on May 30, 2024 1

I tested it locally on the master branch and it works great in Firefox

from komga.

github-actions avatar github-actions commented on May 30, 2024 1

🎉 This issue has been resolved in 1.8.4 (Release Notes)

from komga.

gotson avatar gotson commented on May 30, 2024

I don't quite understand what the symptom is, can you share a video that shows what's the problem?

from komga.

JerwuQu avatar JerwuQu commented on May 30, 2024

Sure! Here's an example: https://www.youtube.com/watch?v=CXAa-pcYABk
Notice that when going to the next page, it goes completely black before showing the page, and how it is instant when going backwards.

For this example I used very high resolution images (6000x10000) to make it really prominent, but I can see it with normal manga too.

from komga.

gotson avatar gotson commented on May 30, 2024

And that symptom only happens on Firefox, is that right?

from komga.

gotson avatar gotson commented on May 30, 2024

Could you share that test cbz you're using? That would save me some time finding / building one for testing.

from komga.

JerwuQu avatar JerwuQu commented on May 30, 2024

The black image can only be seen on Firefox, yes. On Chromium browsers it lags the browser instead.

Here is the cbz: https://drive.google.com/file/d/1HXYs7N0e3lK_V9PYOnvy8DUFOXttoRgm/view?usp=drivesdk

from komga.

gotson avatar gotson commented on May 30, 2024

Thanks for the file. I can reproduce on both Chrome and Firefox. Most of the development of Komga was done on Chrome, until a few weeks ago, which explains why this was never spotted. Chrome handles this slightly better than Firefox in my opinion.

We don't use v-img though, so i need to find another way to render the images before showing them.

from komga.

gotson avatar gotson commented on May 30, 2024

I've done a few tests on Chrome, Firefox and Safari.

Chrome: seems to have some optimization to not render images that have a size but are not in the viewport. No luck there. It's also quite awful at managing page transitions with high definition images. It's always laggy, even after the images have been rendered.

Firefox: I managed to setup some CSS classes to move the images offscreen with a display: block, which makes them render. It works great without page transitions, however when page transitions are enabled, it causes problem. What i managed to do when there are page transitions is to pre-render the i+2 images, so that the transitions to previous/next are smooth. The downside is that if you open a book on page X, the pages X-1 / X+1 will not have been pre-rendered, but the next ones will.

Safari: the most atrocious browser in this test. It doesn't pre-render (like Chrome), and even after the components have been rendered and you go back to previously read pages, it stalls (like Chrome). I think it's agressively disposing of elements that are not displayed anymore, and need to re-render.

from komga.

JerwuQu avatar JerwuQu commented on May 30, 2024

Thanks a lot for your effort in solving this! 🥳

I will give it a try after work.

from komga.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.