[CI] run tsc on PRs and pushes to main

[benjaminpjones]

[CI] run tsc on PRs and pushes to main

[JonKo314]

Yeah, sorry, I should have been more clear: I agree that running tsc on PRs is very useful, but I don't really know about using transpilers. For now I think I'd rather have a dead server, than a running one with hidden bugs due to missing type checks.

[JonKo314]

As long as it isn't too tedious, I'd rather be more strict regarding type checking. So I think Heroku failing is okay.

[benjaminpjones]

On the whole, I'm on board with making our type checking more strict!

The question here though isn't really "how strict do we want it?" but "where do we want to check for it?". I think it's better to see these errors on GitHub (CI) than in Heroku (where we might not see it until someone notices the site has gone down).

[benjaminpjones]

This is actually resolved - "build" already runs as part of the PR workflow, and #243 added tsc to the "build" script.