Giter Site home page Giter Site logo

Comments (7)

fiasco avatar fiasco commented on September 26, 2024

Seems like a good idea, can we get a pull request for it?

from govcms7.

aleayr avatar aleayr commented on September 26, 2024

As part of testing and merging this in, we need to consider how this will effect (and how we test) the change on existing sites.

from govcms7.

fiasco avatar fiasco commented on September 26, 2024

@aleayr agreed, but we need to do that with a pull request provided ;)

from govcms7.

fiasco avatar fiasco commented on September 26, 2024

@typhonius we're keen to see this in govCMS but we need some help:

  1. we need to reroll the PR
  2. we need instructions for how an agency can test this change

from govcms7.

typhonius avatar typhonius commented on September 26, 2024

I've addressed this in #247. An agency should undergo the following steps:

  • Patch govCMS codebase to include change
  • Run update
  • Ensure favicon and iconomist modules are disabled, uninstalled and unable to be reinstalled
  • Ensure that responsive_favicon module is enabled if favicon module was enabled prior.

from govcms7.

aleayr avatar aleayr commented on September 26, 2024

@Venkata-modgu Can we get this tested #247 for merging?

from govcms7.

aleayr avatar aleayr commented on September 26, 2024

Due to complexities in modifying existing customer sites, and depecating this, I'm closing.

from govcms7.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.