Giter Site home page Giter Site logo

Comments (4)

octylFractal avatar octylFractal commented on June 16, 2024

The root cause here is that there is a mandrel distribution that has a version 22 that is jdk_version 17. Perhaps we should only use an allowlist of distributions, instead of all values returned from the foojay API? It could be configurable in an extension if someone needs to change it.

Or, the API match code here could be updated to use jdk_version all the time, since that works for everything and not just GraalVM.

from foojay-toolchains.

StefMa avatar StefMa commented on June 16, 2024

If I open the URL (https://api.foojay.io/disco/v3.0/ids/f668dfc827666d293721a787022fb25b/redirect) on my machine (macOS arm64), it downloads liberica-vm-openjdk11. Looking into the content, it says something like graalvm_f6c97b4e45_java11 22.3.4.

I'm not 100% aware of the diferences between "normal" jdks and graalvm.
But it seems that the plugin requests wrongly a GraalVM distribution because there are 22 versions available (for graal? 🤔 ) but not for "normal" jdks?
Isn't Graal somewhat "special" and therefore should be exlcuded in case there is no vendor specified? 🤔

In this case, I guess, when requesting a 22 Java toolchain, the error would be the same as for version 23.
Because - if i see it correctly - there is no version 22 for "normal jdks" available yet.

from foojay-toolchains.

StefMa avatar StefMa commented on June 16, 2024

Is this fixed with #55 ? 🤔
Can this be closed @jbartok ?

from foojay-toolchains.

jbartok avatar jbartok commented on June 16, 2024

Is this fixed with #55 ? 🤔 Can this be closed @jbartok ?

Yes, thanks for pointing it out!

from foojay-toolchains.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.