New params are missing in final query

[grafana]

New params are missing in final query

[marcusolsson]

Hey, and thank you for using the plugin!

I tried to reproduce this, but it seems to be working for me:

What version of Grafana and the plugin are you currently running?

[debardev]

Grafana v7.3.6
Plugin v0.9.2

It seems to happen only when opening dashboard created for an older grafana-json-datasource (~0.7.0). Probably some backward compatibility issue. It works fine when I create a new dashboard with the latest plugin version.

[marcusolsson]

Hm. The plugin should automatically migrate the old query model to the new format. You can inspect the query model in the panel JSON:

The old format uses the "queryString" property:

  "targets": [
    {
      // ...
      "queryString": "foo=bar-${__from}"
    }
  ],

The new format uses a "params" property

  "targets": [
    {
      // ...
      "params": [
        [
          "foo",
          "bar-${__from}"
        ]
      ]
    }
  ],

When you open an old dashboard and save it, the plugin reads from the queryString property and saves it as params. The old property will still be there, but ignored.

I understand if you decide to just create the dashboards afresh, but if you want to dig deeper. I'd be curious to what went wrong here.