Giter Site home page Giter Site logo

Spurious diffs vs ks diff about tanka HOT 2 CLOSED

grafana avatar grafana commented on May 11, 2024
Spurious diffs vs ks diff

from tanka.

Comments (2)

sh0rez avatar sh0rez commented on May 11, 2024

There seems to be no option to configure go-yaml/yaml, which we currently use at v2.

ksonnet used to use goyaml "github.com/ghodss/yaml", which is a wrapper for our go-yaml, but converts to json first, before actually unmarshalling. This effectively limits us to only a small subset of what yaml is capable of.

The immediate error is caused because of a switch of the yaml library in

tanka/pkg/native/funcs.go

Lines 91 to 101 in 574f946

var manifestYAMLFromJSON = &jsonnet.NativeFunction{
Name: "manifestYamlFromJson",
Params: ast.Identifiers{"json"},
Func: func(data []interface{}) (interface{}, error) {
var input interface{}
dataBytes := []byte(data[0].(string))
if err := json.Unmarshal(dataBytes, &input); err != nil {
return "", err
}
output, err := yaml.Marshal(input)
return string(output), err

Unsure about this
/cc @tomwilkie @gouthamve

from tanka.

stale avatar stale commented on May 11, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from tanka.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.