Giter Site home page Giter Site logo

Comments (4)

philip-ulrich avatar philip-ulrich commented on May 20, 2024 1

I think it depends on how we refactor the code into core. But generally I think it would make sense for this to be in one plugin.

My thoughts on separating them into distinct plugins are:

  1. If we refactor it right, most of the code should be in core so it can be reused by other plugins. Then the code for each plugin will be very simple.
  2. Depending on how it's refactored, it may be easier to split out as separate functions vs handling each arg with separate methods in the class.
  3. I don't want people to feel like they have to modify existing plugins to add features - splitting them out would set precedent that it's encouraged to make as many new plugins as you need.

from bot.

mastrolube avatar mastrolube commented on May 20, 2024

mmhh, for me is better to place all together because it's the same action.. In this case, we have only to change this line
following_status = storage.get_following_status(username) and make it true when use this feature.. (fast thought, maybe we can do better)
so for me, no reason to split the code 👍

from bot.

philip-ulrich avatar philip-ulrich commented on May 20, 2024

This issue has been stagnant for so long, that we are going to ship it in the easiest way. Seems like folks have been pretty busy. 😄

from bot.

philip-ulrich avatar philip-ulrich commented on May 20, 2024

This is added in the upcoming v1.2.0. Closing the issue to clean things up.

from bot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.