Comments (4)
I think it depends on how we refactor the code into core. But generally I think it would make sense for this to be in one plugin.
My thoughts on separating them into distinct plugins are:
- If we refactor it right, most of the code should be in core so it can be reused by other plugins. Then the code for each plugin will be very simple.
- Depending on how it's refactored, it may be easier to split out as separate functions vs handling each arg with separate methods in the class.
- I don't want people to feel like they have to modify existing plugins to add features - splitting them out would set precedent that it's encouraged to make as many new plugins as you need.
from bot.
mmhh, for me is better to place all together because it's the same action.. In this case, we have only to change this line
following_status = storage.get_following_status(username) and make it true when use this feature.. (fast thought, maybe we can do better)
so for me, no reason to split the code 👍
from bot.
This issue has been stagnant for so long, that we are going to ship it in the easiest way. Seems like folks have been pretty busy. 😄
from bot.
This is added in the upcoming v1.2.0. Closing the issue to clean things up.
from bot.
Related Issues (20)
- error and bot crashes all the time
- Tagged posts
- row_feed_photo_profile_name contains text/desc object only for video HOT 3
- Not possible to use version 263.2.0.19.104 anymore HOT 8
- Samsung Galaxy S9+ install through Termux is not working | Failed building wheel for 1xml ERROR: Could not build wheels for 1xml, which is required to install pyproject.toml-based projects HOT 8
- cant use pm_list.txt HOT 1
- Unfollowing Job Continuesly Scrolls and does not Iterate HOT 5
- Unable to verify python3 and pip HOT 2
- Unable to install requirements HOT 2
- Always stopped by time delta HOT 3
- Can't use filter HOT 4
- can`t intall GramAddict HOT 4
- [Feature request] Auto upload for professional accounts HOT 1
- Failed to check if comment succeed. HOT 1
- gramaddict init "MyUsername" - Does not download the default settings to user
- ModuleNotFoundError: No module named 'pkg_resources' HOT 3
- Uiautomator started failed
- I got this error the first time I started
- ChunkedEncodingError HOT 1
- uiautomator2 crashes when sessions starts
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bot.