Comments (5)
It'd seem so; I think the docs probably need to be updated.
from dataloader.
I just made some updates to Readme that hopefully improve this. Your suggestion is half-correct. If the entire batch request fails, then cache is cleared. If individual values are provided Error
, those are cached. I updated the language to make this clear.
from dataloader.
Thanks, i got your point.
However, in real world from what i see, it rarely happens when individual values are provided Error
, because batch function is designed to reduce network cost of fetching data to backend. For example, a batch function to load data from a rational database may look like this:
var batchFn = ids => {
return new Promise((resolve, reject) => {
sqlRun(`SELECT * FROM user_table WHERE ID IN (${ids.join(',')})`, (err, records) => {
if (err) {
return reject(err);
} else {
return resolve(records);
}
});
});
};
rather than
var batchFn = ids => {
return Promise.all(ids.map(id => {
return new Promise((resolve, reject) => {
sqlRun(`SELECT * FROM user_table WHERE id=${id}`, (err, record) => {
if (err) {
return reject(err);
} else {
return resolve(record);
}
});
});
}));
}
from dataloader.
It certainly depends on the system you're communicating with, and of course it's up to how you implement your batching function. There is of course the case where the batch itself fails, which is well illustrated by your first example. There is also a case where your batch function may return a combination of values and errors. That is - the batch load itself succeeded however some of the individual operations within the batch failed.
from dataloader.
Agreed, just to share my thoughts, thanks!
from dataloader.
Related Issues (20)
- Move CI to GitHub Actions
- Setup publish token for CI
- Change default branch `master` to `main` HOT 1
- Setup Renovate Bot to keep dependencies up to date HOT 3
- [QUESTION] Why aren't keys being de-duplicated even when the cache is disabled? HOT 6
- ✨ [REQUEST]: Add examples for cacheKeyFn and cacheMap HOT 2
- [REQUEST]: How to pass auth headers to dataloader HOT 4
- [QUESTION] README.md doesn't show on npmjs.com HOT 2
- CacheMap.get calls should await the promised value HOT 1
- [QUESTION] Release changes? HOT 9
- [QUESTION] name is now required in options? HOT 4
- [BUG] Readme is missing from NPM HOT 2
- [BUG] `this` context not available in typescript definitions
- [BUG] Use caution with `jest.useFakeTimers()` HOT 1
- [REQUEST] support vercel edge functions by default HOT 4
- Ever considered the use of `queueMicrotask`? HOT 1
- Coalescing multiple load() calls HOT 3
- [REQUEST] Unify the way `load` and `loadMany` handle errors
- -
- [REQUEST] Add batch grouping
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dataloader.