Comments (2)
@r0mant How are they pushing a different tag than what is in the Makefile? You just run make update-tag
and it uses the VERSION
set in the Makefile. You have to do extra work to get this wrong and I'm not sure why anyone would?
I do plan do fix this - I've been thinking about this yesterday - I don't think we need to tag dev builds at all any more. We used to trigger the build off the tag but since we do not any more, we should just be able to do make dev-build VERSION=1.2.3-dev.username.foo.1
or similar and have it build the current commit. I have some other thinking about this which I'll detail shortly.
This issue is perhaps the same as https://github.com/gravitational/teleport.e/issues/2021 (Fix regressions in release pipeline) which is what I've started working on, but there is a lot of churn in the release workflows with the *-stage
work that I've been letting that settle first. That issue is a touch more broad though given it is also about publishing to the release server.
from teleport.
You have to do extra work to get this wrong and I'm not sure why anyone would?
I'm the one who did this. I was making a dev build off of a dev branch, so rather than waiting for a PR to merge to a release branch and tagging that commit, I tagged my dev branch directly.
- Updated makefile with dev version
- Ran
make update-version
- Committed the results
- Before running
make update-tag
, realized I wanted to change the tag. - Updated makefile to alter tag.
- Ran
make update-version
- forgot to commit results
- Ran
make update-tag
.
The final invocation of make update-tag
pushed the tag that matched my local version, but the latest commit pushed to origin still had the original version number in it.
One way to prevent this would be for make update-tag
to fail if your local git state is not clean. That would have prevented me from hitting this issue and make me realize I need to commit my version changes before proceeding.
from teleport.
Related Issues (20)
- `TestAccessRequestCacheBasics` flakiness HOT 1
- Deleting a role which is assigned by an access list can prevent logging into a cluster
- Add SAML logout endpoint HOT 4
- teleport-cluster-auth-test job failing when upgrading from 15.2.5 to 15.3.0 HOT 4
- Update SSO references to Microsoft Entra ID HOT 1
- Add repo for Ubuntu 24.04 LTS (Noble Numbat) HOT 1
- Prometheus Metrics for `failed_login_attempts_total` are not incrementing. HOT 1
- Usage in Self Hosted clusters UI HOT 1
- Reload systemd config after an upgrade
- SSH sessions running `tmux` don't play back correctly using `tsh play` HOT 3
- Web UI: remove free-form login entry
- Include min password length for local users in local connector info
- Autocomplete Reviewers field in Just in Time Access Requests HOT 1
- [helm] Don't hard-code `.cluster.local` in the `teleport-cluster` chart
- Reject outdated agents by default
- Teleport can't connect to S3 FIPS endpoint HOT 1
- Host user creation does not update user groups in `keep` mode
- Phone Number Change HOT 1
- Support AWS CodeCommit through Teleport Application Access
- docs: show starting fluentd in datadog log exporter integration.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from teleport.