Giter Site home page Giter Site logo

Comments (3)

greglook avatar greglook commented on August 17, 2024

Thanks for the detailed report! This sounds like an issue at a deeper layer than puget; the print width is passed directly to fipp, and the only interaction that I can think of that is implicated by the colorization is the use of :pass nodes to avoid counting color markup against the document width. I'm not sure why this would show up only at higher widths, unless the behavior of rrb-vector somehow alters at larger sizes.

from puget.

greglook avatar greglook commented on August 17, 2024

Some brief experimentation seems to indicate that this is related to the size of the data structure passed to fipp. Inspecting the print document being rendered showed that puget was doing some (very slightly) suboptimal behavior by passing a no-op [:align ()] structure inside empty collections. Removing this did not fix the problem, but it did raise the :width limit at which the error occurs by the same amount as the number of empty collections in your bad-data sample, which seems significant.

from puget.

aeriksson avatar aeriksson commented on August 17, 2024

I also did some digging, and I agree that it doesn't seem likely that the bug is in puget. I've filed the following issue for fipp: brandonbloom/fipp#53

I have a hunch that the bug is actually in in clojure.core.rrb-vector. However, my attempts to produce a rrb-vector-only test case that triggers the bug have been unsuccessful.

from puget.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.