Giter Site home page Giter Site logo

Fork about captcha HOT 15 OPEN

S1SYPHOS avatar S1SYPHOS commented on September 25, 2024
Fork

from captcha.

Comments (15)

jshah4517 avatar jshah4517 commented on September 25, 2024 4

@Gregwar Would be great if you could merge the above, that looks like all that is needed at the moment.

from captcha.

diversen avatar diversen commented on September 25, 2024 2

I also forked this to https://github.com/diversen/Captcha
It just fixes the issues #100
Which means that it will work on php8.1 (at least in my use-case)

from captcha.

Gregwar avatar Gregwar commented on September 25, 2024 2

I see, it drifted too much
I will try to find a slot to ensure that this is compatible with 8.0 / 8.1 at least (and doesn't break Sf bundle as well)

from captcha.

Gregwar avatar Gregwar commented on September 25, 2024 2

Hello,
I am not sure to understand your bullet points:

  1. and 2) are just workflow/packaging things, how does it prevent PHP from working with PHP8 ?
  2. is merged already, 4) is fixed

I also tagged v1.2.1 to ensure composer re-packaging

from captcha.

S1SYPHOS avatar S1SYPHOS commented on September 25, 2024 1

I did a little more than that 😀

from captcha.

Gregwar avatar Gregwar commented on September 25, 2024 1

Hello,
@S1SYPHOS would you mind reflecting your changes here ?
I am sorry I only have little time to maintain this repository, I am ok with other people taking care 🙂

from captcha.

S1SYPHOS avatar S1SYPHOS commented on September 25, 2024 1

@Gregwar Sorry for my late reply, but here goes:

First of all, I fixed #60, #80, #84, #91 and #100 and applied PRs #74, #89, #92, #95 and #101. While doing so, I refactored a lot of code and added full support for PHP8. Most changes are listed below the first v2 beta release, see here.

Later on, I added features like "background noise" (using small random letters), custom fonts and optional support for tesseract-ocr, hex color support was added as well as docstrings and such, writing virtual files when testing, improved (yet still basic) tests .. and just keeping things as DRY as possible 😁

from captcha.

bytestream avatar bytestream commented on September 25, 2024 1

@Gregwar I think at a minimum you can merge the below to cover PHP 8.0 and 8.1 without breaking anything:

  1. #105
  2. #106
  3. #101
  4. #92

from captcha.

blankse avatar blankse commented on September 25, 2024

@S1SYPHOS Do you plan to create a Symfony Bundle for it? We have issues there and get no response. See Gregwar/CaptchaBundle#231

from captcha.

S1SYPHOS avatar S1SYPHOS commented on September 25, 2024

@blankse I didn't plan to, and frankly I don't think I will, since I don't use Symfony myself. I don't know how to properly setup & test such a plugin, and looking at the PRs and issues on the plugin this seems like quite a lot of work ..

I'm sorry, but that's something @Gregwar would have to take care of.

from captcha.

bytestream avatar bytestream commented on September 25, 2024

@Gregwar I can help in a maintenance capacity if you'd like.

from captcha.

Gregwar avatar Gregwar commented on September 25, 2024

If it is still code compatible with the current version (keeps most of BC, especially the Sf bundle), maybe we could change things here directly, would you agree doing that @S1SYPHOS , if I add you to the owners ?

@bytestream are you using the Sf Bundle? Looks like @S1SYPHOS is not using it so maybe we can have another pair of eyes on this matter to keep things compatible 🙂

from captcha.

bytestream avatar bytestream commented on September 25, 2024

@bytestream are you using the Sf Bundle?

I'm afraid not. We use Laravel and are using this package directly.

from captcha.

S1SYPHOS avatar S1SYPHOS commented on September 25, 2024

At this point, it's not even close to being compatible 😀 since I'm not using Symfony (never have tbh), I don't know how to test this even if I helped migrate the bundle 😕

from captcha.

bytestream avatar bytestream commented on September 25, 2024

@Gregwar do you still want some help with maintenance of this library?

from captcha.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.