Giter Site home page Giter Site logo

Data race about gogtrends HOT 4 CLOSED

groovili avatar groovili commented on July 19, 2024
Data race

from gogtrends.

Comments (4)

loeffel-io avatar loeffel-io commented on July 19, 2024

Not 100% sure if this is an gogtrends issue

from gogtrends.

groovili avatar groovili commented on July 19, 2024

Hi @loeffel-io!

Can you describe steps to reproduce the issue?
According to logs you've sent, data race happens on r.Header.Set(headerKeyCookie, cookie[0]). Headers are map and access by key possibly can be not safe for concurrent usage.
But on every call to client new request is created.

I've found data races with shared defParams, which actually url.Values = map[string][]string and cached locations and categories. It's fixed in #14, also simple tests with concurrent usage are added.

from gogtrends.

loeffel-io avatar loeffel-io commented on July 19, 2024

Thanks @groovili

You can safe the map with an external or "parent" struct mutex.

I will report if any issue still exists, thank you for your work!

from gogtrends.

groovili avatar groovili commented on July 19, 2024

Thanks @loeffel-io
Feedback is important to me and I feel great when somebody finds my package useful.

from gogtrends.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.