Comments (2)
Thank you for letting me know that. But it looks to be an issue in protoc
or googleapis
.
Let me confirm to the upstream.
Although the extension google.api.http
in MethodOptions
is an optional field, protoc
emits as if it is a repeated field for the syntax (2). I am not sure what is the expected behavior.
Some possibilities come to my mind.
protoc
should have combined those lines into one extension if the two variations of syntax mean the same thing?- goprotobuf should have done it?
google.api.http
should have been repeated field and grpc-gateway should have combine the repeated values into one?
Here is the dump of the code generation request.
...
name: "EchoBody"
input_type: ".gengo.grpc.gateway.example.SimpleMessage"
output_type: ".gengo.grpc.gateway.example.SimpleMessage"
options: <
/* 38 unknown bytes */
72295728: "\"\x15/v1/example/echo_body"
72295728: ":\x01*"
>
from grpc-gateway.
Hi Yuki,
I found: protocolbuffers/protobuf#59
So seems more like a protoc issue, unfortunately.
2015-06-01 22:10 GMT+09:00 Yuki Yugui Sonoda [email protected]:
Thank you for letting me know that. But it looks to be an issue in protoc
or googleapis.
Let me confirm to the upstream.Although the extension google.api.http in MethodOptions is an optional
field, protoc emits as if it is a repeated field for the syntax (2). I am
not sure what is the expected behavior.Some possibilities come to my mind.
- protoc should have combined those lines into one extension if the
two variations of syntax mean the same thing?- goprotobuf should have done it?
- google.api.http should have been repeated field and grpc-gateway
should have combine the repeated values into one?Here is the dump of the code generation request.
...
name: "EchoBody"
input_type: ".gengo.grpc.gateway.example.SimpleMessage"
output_type: ".gengo.grpc.gateway.example.SimpleMessage"
options: <
/* 38 unknown bytes /
72295728: ""\x15/v1/example/echo_body"
72295728: ":\x01"
>—
Reply to this email directly or view it on GitHub
#16 (comment).
from grpc-gateway.
Related Issues (20)
- Internal comments not stripped from enum query parameter's description HOT 2
- Fetching request body in the customErrorHandler middleware HOT 5
- Buf - Wrong import in grpcgateway HOT 1
- Document about how to mark an arrray field as required in an extra openapi config file? HOT 1
- multi-folder not generating correct swagger file HOT 2
- [protoc-gen-openapiv2] Option to disable setting default values for enums without omitting it from the list of values HOT 3
- openapiv2_tag.name does not work HOT 4
- Grpc Gateway discards Any typed fields HOT 2
- Populating query param semantics changed since v2.15.0 HOT 3
- When the body is set to a oneof field, other fields in the same group are included as query.
- For a field of type google.protobuf.Empty, FieldMaskFromRequestBody does not generate any fieldmask HOT 3
- generate swagger schema title and description failed HOT 2
- Issue with importing "github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-grpc-gateway" HOT 3
- genopenapi: Stable openapi names for nested types HOT 1
- snake_case response HOT 1
- api_visibility doesn't transitively apply to rpc request/response messages HOT 2
- protoc-gen-grpc-gateway and protoc-gen-openapiv2 return incorrect version HOT 1
- Dependency on google.golang.org/grpc/health/grpc_health_v1 conflicts with custom proto marshallers HOT 5
- JSONPb marshaler doesn't use indent on non proto fields
- WriteHeader is not called on 200s HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grpc-gateway.