Giter Site home page Giter Site logo

Comments (1)

gtker avatar gtker commented on August 16, 2024

The SMSG_ADDON_INFO definition has been changed to use a custom type instead of the skip_serialize tag since this message is the only one that requires this work around for Vanilla/TBC/Wrath.

Using Predrag's guide to sealed traits, the Message trait should be a private trait to prevent downstream crates from using it at all.
The only reason it exists is to prevent code duplication in the different major version Server/ClientMessage implementations.
Since calling read_body can panic for the Wrath version of SMSG_ADDON_INFO it is not safe to use without explicitly ensuring that this won't be called.
This can be done internally in the expected helper functions but would probably not be doable outside of the crate.

The Server/ClientMessage traits should be supertrait sealed trait, since downstream should be able to use it but not impl it.

from wow_messages.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.