Comments (1)
The SMSG_ADDON_INFO
definition has been changed to use a custom type instead of the skip_serialize
tag since this message is the only one that requires this work around for Vanilla/TBC/Wrath.
Using Predrag's guide to sealed traits, the Message
trait should be a private trait
to prevent downstream crates from using it at all.
The only reason it exists is to prevent code duplication in the different major version Server/ClientMessage
implementations.
Since calling read_body
can panic for the Wrath version of SMSG_ADDON_INFO
it is not safe to use without explicitly ensuring that this won't be called.
This can be done internally in the expected
helper functions but would probably not be doable outside of the crate.
The Server/ClientMessage
traits should be supertrait sealed trait
, since downstream should be able to use it but not impl it.
from wow_messages.
Related Issues (20)
- Add name lookup for items/spells
- Incorrect 3.3.5 SMSG_ACCOUNT_DATA_TIMES parsing HOT 9
- WOTLK: ServerOpcodeMessage::read_encrypted causing a stack overflow HOT 4
- WOTLK: SMSG_MOTD is incorrect HOT 2
- Generated code makes rust_analyzer slow HOT 1
- Some types in .wowm are not passed to IR HOT 1
- `read_sized_c_string_to_vec` can cause a out of memory crash HOT 1
- Improve fuzzability HOT 1
- `bool` implementation is not parse->encode stable HOT 1
- Confusing `tag_all versions` overlapping individual item `versions` HOT 2
- `SMSG_ACCOUNT_DATA_TIMES` for 3.3.5 should not have `u32[-]` HOT 1
- Invalid date in test case for SMSG_LOGIN_SETTIMESPEED
- Arrays without comma separation HOT 1
- Typo in Expansion enum
- Confusing message and structure field tags HOT 3
- Investigate `CMD_SURVEY_RESULT.data` compression HOT 1
- 3.3.5a MovementBlock docs are inaccurate HOT 3
- 3.3.5a SMSG_UPDATE_OBJECT minimum required fields to spawn player HOT 2
- 3.3.5a Missing Fields HOT 1
- AuraUpdate NOT_CASTER check HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wow_messages.