Giter Site home page Giter Site logo

Comments (7)

gusparis avatar gusparis commented on August 27, 2024 1

Yes. It will give you an error for what I said on my previous comment, is not a component but a module. Let me work on a poc for the buttons and then I'll upload it after working. 😞

from react-native-month-year-picker.

apgsn avatar apgsn commented on August 27, 2024 1

Hey man, great job! The neutral button is working as intended.
Thank you so much for this new feature. 👍

from react-native-month-year-picker.

gusparis avatar gusparis commented on August 27, 2024

Hello @apgsn! Thanks for using the library! Hrmm interesting change request...the array you're suggesting could work for iOS out of the box, the issue with will be for Android and the dialog implementation I'm using. It will take me a little more to refactor to inflate the Dialog with custom buttons. An easy way would be to add an optional third button (called neutral on Android). Let me know your thoughts.

from react-native-month-year-picker.

apgsn avatar apgsn commented on August 27, 2024

I was able to hack an extra button in iOS by adding it as a child of your component, but Android gives me an error so it's impossible right now to do it.
I'd say any solution that gives me an extra button on both platforms is golden.

Another idea would be to give the users a way to import the bare calendars and use them as they please without extra modals, buttons, or fade animations.

from react-native-month-year-picker.

gusparis avatar gusparis commented on August 27, 2024

Again the issue here is Android ðŸĪŠ. You can have the iOS bare component right now, importing the ViewComponent directly (without the wrapper). On Android this cannot be done because is not a component, but a module that fires a Java method. To have the bare Android it will require a huge refactor.

from react-native-month-year-picker.

apgsn avatar apgsn commented on August 27, 2024

I was digging through the code and saw that, bummer. But there's still a way to add a neutral button, right?

from react-native-month-year-picker.

gusparis avatar gusparis commented on August 27, 2024

@apgsn check new version 1.5.0 and let me know your thoughts about the new button. I will work next on a decouple version of the component, to give the freedom to use it anywhere, but leaving the Dialog/Modal available through props.

from react-native-month-year-picker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google âĪïļ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.