Neutral button stops firing (iOS)

[gusparis]

Neutral button stops firing (iOS)

[gusparis]

Hey @apgsn ! How's it going?
That's some weird behavior you have there. Let me check. I think I might know why this is happening.

[gusparis]

@apgsn I tested the component for about 15 min, and the neutral action is firing as expected. Please update with the steps to reproduce it once you have them. 👋🏼 👋🏼 👋🏼

[apgsn]

Thanks for looking into it! Next week I'll see if I can find a way to replicate the bug consistently.

[gusparis]

Closed due to inactivity. Reopen if needed.

[SmirnovM91]

Hello, I have the same problem

[SmirnovM91]

I've fixed it by replacing nil to self at 41 line in RNMonthPicker+Toolbar.m

UIBarButtonItem *neutralButton = [[UIBarButtonItem alloc] initWithTitle:_neutralButtonLabel style:UIBarButtonItemStylePlain target:self action:@selector(onNeutralButton)];

[PunainenAurinko]

This is still happening in v.1.6.4. After a while of use (multiple month/year) combinations being selected, the neutral button click stops triggering any event at all. I think the above code would fix this issue. Is it possible to make that change in the module?

[PunainenAurinko]

@gusparis Hi Gustavo, why was this closed? This issue is still happening in v. 1.6.4. Neutral button randomly stops firing on iOS (I'm on 14.6). SmirnovM91 solution works but needs to be included in the library as a PR.

[gusparis]

🎉 This issue has been resolved in version 1.7.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀