Pool promise wait() breaks with guzzlehttp/promises v2

[compwright]

Pool promise wait() breaks with guzzlehttp/promises v2

[GrahamCampbell]

Can you pin point the exact package versions that changed. Did the version of our promises library change when you upgraded, too?

[compwright]

Yes, and yes - see https://github.com/guzzle/guzzle/blob/7.8/CHANGELOG.md#770---2023-05-21

[GrahamCampbell]

I'm not asking about the change log, I'm asking about the actual versions installed for you before and after.

[compwright]

I thought I answered that already, but I'll spell it out:

7.6.1 works (uses guzzle/promises 1.5.3)

7.7.0 doesn't work (uses guzzle/promises 2.0.0). Ditto for 7.7.1 and 7.8.0, and guzzle/promises 2.0.1.

[compwright]

@GrahamCampbell thanks for looking into this!

[GrahamCampbell]

Does downgrading to promises 1.5.3 with 7.7.0 work?

[compwright]

@GrahamCampbell yes, 7.7.0 and 7.8.0 work as expected with guzzle/promises 1.5.3.

[GrahamCampbell]

Hmm, pretty odd, given we basically didn't change anything: guzzle/promises@1.5.3...2.0.1. Can you spot the issue in here? I'm not sure there's much else I can do to help, otherwise.

[compwright]

By way of update, this happens when the callbacks the iterable returns return a promise. It seems that the pool does not automatically resolve each promise; the callback needs to handle that itself.