Giter Site home page Giter Site logo

Comments (3)

twood02 avatar twood02 commented on August 23, 2024

you should integrate the timer into the simple client and you should fix the bug in the histogram related to adding values that are larger than the biggest histogram bucket (check with @akorzan if you need more details).

You should also change the client so that it can perform N requests (a command line argument). Remember that each request should create its own socket.

Actually, since it will be difficult to test this without having an actual memcached server to send to, you could add this code to the trivial-client example in the repo. If you can make the timing and histogramming work correctly for that, it should be trivial to port it over to our real client later. This will also limit merge conflicts since the Client team is going to be making major modifications to the client's structure. Make sense?

from gw-kv-store.

Chryel avatar Chryel commented on August 23, 2024

In order to avoid the segmentation faults when adding a value that is not within the histogram's bucket range, I added a second part to the if statement in histogram_inc in order to catch any values over the range. I incremented an added value called "missed_counter" to indicate to the users that there were missed values and modified the histogram_print function accordingly.

The last function of timer_end in the timer_util file had conflicting errors with an identically named function, and was renamed to timer_end_hist.

The "trivial" folder contains both trivial-client and trivial-server. It also contains socket_helper that is required for both files. I've tested the client by running "./trivial-client -r 1000" to simulate 1000 connections and it seems to work fine.

Unfortunately, I've worked on this on a separate branch of adv-net-samples, so I will be making an appropriate pull request on that repo.

from gw-kv-store.

twood02 avatar twood02 commented on August 23, 2024

@Chryel @SMonaghan - please update this Issue or close it and create a new one listing exactly what is remaining and who will do what

from gw-kv-store.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.