Comments (3)
you should integrate the timer into the simple client and you should fix the bug in the histogram related to adding values that are larger than the biggest histogram bucket (check with @akorzan if you need more details).
You should also change the client so that it can perform N requests (a command line argument). Remember that each request should create its own socket.
Actually, since it will be difficult to test this without having an actual memcached server to send to, you could add this code to the trivial-client
example in the repo. If you can make the timing and histogramming work correctly for that, it should be trivial to port it over to our real client later. This will also limit merge conflicts since the Client team is going to be making major modifications to the client's structure. Make sense?
from gw-kv-store.
In order to avoid the segmentation faults when adding a value that is not within the histogram's bucket range, I added a second part to the if statement in histogram_inc in order to catch any values over the range. I incremented an added value called "missed_counter" to indicate to the users that there were missed values and modified the histogram_print function accordingly.
The last function of timer_end in the timer_util file had conflicting errors with an identically named function, and was renamed to timer_end_hist.
The "trivial" folder contains both trivial-client and trivial-server. It also contains socket_helper that is required for both files. I've tested the client by running "./trivial-client -r 1000" to simulate 1000 connections and it seems to work fine.
Unfortunately, I've worked on this on a separate branch of adv-net-samples, so I will be making an appropriate pull request on that repo.
from gw-kv-store.
@Chryel @SMonaghan - please update this Issue or close it and create a new one listing exactly what is remaining and who will do what
from gw-kv-store.
Related Issues (20)
- KV data storage
- Server architecture (simple)
- server architecture (threaded)
- server architecture (thread pool w/polling)
- Server architecture (select)
- Client: Process second line of response(data block). HOT 2
- Group 4 task: create socket, accept connection, call parse_message, process_operation and send_reply HOT 9
- Hashtable Wrapper
- Client group: Finish API Conversion HOT 4
- Fix ht-wrapper Test HOT 4
- Travis CI Unit Tests HOT 5
- Handler HOT 3
- Marshalling/Demarshalling APIs HOT 11
- Final Push HOT 6
- Client Side: Resolve Demarshall HOT 7
- Marshalling/Demarshalling Issues HOT 2
- Handle key not found with END HOT 3
- file headers HOT 2
- client api and tests HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gw-kv-store.