Timezone Support and PostgreSQL

[gx0r]

Timezone Support and PostgreSQL

[gx0r]

Thanks! Pulled. If I understand correctly, without this, Postgres interprets timestamp as being local time, even though it is UTC (since toISOString gives a UTC time). With patch, postgres interprets it as UTC.

[micheee]

Yes, at least from what I understood, but I am by no means a postgres expert.
Thanks!
Michael

[sboehler]

Hi, I believe this is not properly fixed yet, at least in my case it doesn't work (v1.0.19)

When saving the 'expired' time stamp in the "set" method:

• new Date(expired).toISOString() returns a timestamp in UTC
• knex sends that timestamp to postgresql, and because the column "expired" in Postgres has no tz information, the tz is simply ignored and the timestamp is interpreted and saved as local time (CET in my case).

I discovered this because I set my session cookie to expire in 1 hour with my machine being running in CET, which currently is one hour ahead of UTC. The effect was that all my sessions instantly expired.

I believe the proper fix is to set the 'expired' column for postgresql to "timestamp with time zone" by removing the "true" parameter on line 101 (version 1.0.19). Only then postgresql will consider the time zone information in the ISO string.