Giter Site home page Giter Site logo

Comments (11)

gyli avatar gyli commented on July 18, 2024

This is the expected result, as the default drawing direction is from bottom left going up, then going right.
The starting location could be changed through parameter starting_location, and the direction could be changed through vertical. You can find more examples here https://pywaffle.readthedocs.io/en/latest/examples/block_shape_distance_location_and_direction.html

from pywaffle.

cpbl avatar cpbl commented on July 18, 2024

Hi @gyli. Thanks for your package.

Those examples do not address the question of keeping colours contiguous. You can consider this a feature request rather than a bug if you like, but I'm saying currently the output doesn't look good. It would look much better if the yellow blocks were contiguous, and I think your code could be fixed to ensure that --- or to give it as another option.

from pywaffle.

gyli avatar gyli commented on July 18, 2024

I'm sorry that I din't get your point of keeping colors contiguous. If you take a look of the similar example in the README page, it is drawing from upper left to bottom right, while it does not avoid yellow blocks being separated, since there's just not enough blocks.
So in this case, what do you suggest to make yellow blocks being together? Making a new option to force each color starting from a new column maybe?

https://github.com/gyli/PyWaffle/raw/master/examples/readme/title_and_legend.svg

from pywaffle.

cpbl avatar cpbl commented on July 18, 2024

That's not necessary.
But it should draw down the first column, then up the next column, then down the next column, etc.
Then colours would never be broken up.

from pywaffle.

gyli avatar gyli commented on July 18, 2024

OK, that's also what I mean. I think we can do an option allowing this.

from pywaffle.

gyli avatar gyli commented on July 18, 2024

Just to confirm, is this what you thought? Every color starts from a new column so blocks with same color could be together. I am working on a new option to allow this.
Figure_1

from pywaffle.

cpbl avatar cpbl commented on July 18, 2024

No. That is painted top to bottom on every column.
My suggestion is to alternate directions on each column.

from pywaffle.

cpbl avatar cpbl commented on July 18, 2024

The point is never to jump from the top to the bottom, or bottom to top, when you're painting. Lay down squares by snaking back and forth.

Look at my first example at the top of this Issue.
The last two yellow squares should be at the top of their column, right next to the last yellow square painted in the previous column.

from pywaffle.

gyli avatar gyli commented on July 18, 2024

I see. That is a good point!

from pywaffle.

gyli avatar gyli commented on July 18, 2024

@cpbl The feature is added in the latest version 0.6.0. Use parameter block_arranging_style='snake' to enable it.

Doc could be found here https://pywaffle.readthedocs.io/en/latest/examples/block_shape_distance_location_and_direction.html#where-to-start-each-category

Thanks again for this great idea!

from pywaffle.

cpbl avatar cpbl commented on July 18, 2024

Nice work, and thank you for this addition and for the project.

from pywaffle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.