HTTP Request with roundtripper is not being intercepted

[sefasenturk95]

HTTP Request with roundtripper is not being intercepted

[arcln]

I join others thinking it should be possible to test RoundTrippers.

A workaround is to use gock.DefaultTransport as the underlying transport in your custom transport :

// Instead of intercepting the http client
// gock.InterceptClient(httpClient)

// Send requests to gock's transport manually
myTransport := httpClient.Transport.(*MyTransport)
myTransport.delegateTransport = gock.DefaultTransport

[h2non]

gock does a runtime patching in order to intercept HTTP traffic at http.Transport > RoundTrip level, hence that's the reason it doesn't work if you are overwriting the transport RoundTrip with a custom implementation after mocking the http.Client.
You can see implementation details here: https://github.com/h2non/gock/blob/master/transport.go#L25-L86

That being said, it's not recommended that your custom logic goes at transport level. That responsability should be done in a higher layer, not during the request round trip phase.

If you need to write non-trivial HTTP clients that share intermediate logic, I would suggest you taking a look to gentleman toolkit, which allows you to define plugabble middleware logic easily: https://github.com/h2non/gentleman

[billinghamj]

+1 to this. We use a custom transport to apply auth. It is entirely recommended to set your transport-layer auth using a custom transport.

At the very least, it should detect custom transports and warn the user, and it should be documented as a limitation in the readme.

Or, yanno, it could just wrap the custom transport.

[billinghamj]

If you want to use TLS client certificates, then you HAVE to use a custom transport

[leandromoreira]

It seems also that the way to add keepalive at client side is by swaping to a custom transport.

[martin-dos-santos]

+1

[wildsurfer]

Facing the same issue with testing the custom roundtripper