Multiple notifications in parrallel

[h2soft]

Multiple notifications in parrallel

[mamaral]

+1

[mamaral]

I'm not a node js guy, but it appears to me this is probably due to there being n listeners created when you send n requests in a loop, and if one hits the error case it emits the sent event with that error and ALL of those n listeners are listening for it, so they ALL handle the error event.

That explains why if you send n notifications and 1 fails, you get n callbacks with that error.

[Neamar]

Yeah, when you look at the code it uses if (cb) this.once('sent', cb);, so if you send multiple notifications in parallel using the same object it will only notify one cb :\

[Neamar]

Fix: create a new GCM object everytime you need to send something in parallel.
Alternative fix (require changes in the library): edit code to remove calls to self.emit('sent', ...) by direct calls to cb().

@h2soft I can send a PR, will you merge it and publish to npm?