Giter Site home page Giter Site logo

Comments (3)

hackerkid avatar hackerkid commented on September 26, 2024

I am using XMLHttpRequest package for the module which handles the error automatically. But I would try to figure out a way to implement Error-First Callbacks by using a different package. Thanks for letting know. I am leaving the issue open.

from node-github-notification.

dotnetCarpenter avatar dotnetCarpenter commented on September 26, 2024

You don't need to use a different package and I'm afraid that XMLHttpRequest does not handle errors for you.

What happens if

  1. the connection is lost?
  2. the server doesn't response?
  3. the JSON is malformed?
    These things can be tested
  4. try to disconnect your pc while making a request
  5. try writing a wrong URL to see what I mean
  6. try to retreat a local JSON file that you deliberate made a mistake in

I'll send you a PR with the change.

from node-github-notification.

hackerkid avatar hackerkid commented on September 26, 2024

Merged. Closing the issue. Thanks.

from node-github-notification.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.