Giter Site home page Giter Site logo

Comments (10)

navjotsingh96 avatar navjotsingh96 commented on June 14, 2024 1

Thanks for the help. It works now.

I thought about this a little bit more and I think it would be nice if the library could try to auto-detect anchor element's scroll container since it seems to be a common issue. If I have time, I'll take a look at this next week.

It would be better.

I think that a line under the scrollContainer section in the docs would be good, telling us how to first figure out scrollContainer and then bind it. As in my case, I thought that sidebar-content is scrollContainer, but it's mat-drawer-container.
So short introduction for now to reduce this kind of issues.

from ngx-ui-tour.

hakimio avatar hakimio commented on June 14, 2024

The author had partially fixed #152 in PR #154.

from ngx-ui-tour.

navjotsingh96 avatar navjotsingh96 commented on June 14, 2024

@hakimio Thanks for your reply.

Is the fix already included in the latest version or not? If yes, why is this the case?

If you disable backdrop, it is still wrong

from ngx-ui-tour.

hakimio avatar hakimio commented on June 14, 2024

Check issue #138 to see if the same solution of setting scroll container config fixes your issue as well.

from ngx-ui-tour.

navjotsingh96 avatar navjotsingh96 commented on June 14, 2024

unfortunately not

from ngx-ui-tour.

hakimio avatar hakimio commented on June 14, 2024

Seems to be working after setting scrollContainer and making some minor CSS adjustments:
https://stackblitz.com/edit/stackblitz-starters-4jxxoc

from ngx-ui-tour.

hakimio avatar hakimio commented on June 14, 2024

The tour needs to know the scroll container for the animated scroll to work. Otherwise you can disable the animated scrolling if you don't want to deal with setting the scroll container.

from ngx-ui-tour.

hakimio avatar hakimio commented on June 14, 2024

I thought about this a little bit more and I think it would be nice if the library could try to auto-detect anchor element's scroll container since it seems to be a common issue. If I have time, I'll take a look at this next week.

from ngx-ui-tour.

hakimio avatar hakimio commented on June 14, 2024

If you have some good ideas how to improve the docs, feel free to open a PR.

from ngx-ui-tour.

hakimio avatar hakimio commented on June 14, 2024

Implemented in v12.1.0.

from ngx-ui-tour.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.