Comments (9)
Should we use naming scheme ListMatchers, CoreMatchers, ObjectMatchers, etc? Reads better to me and avoids having to rename some existing factories (e.g. FileMatchers).
from javahamcrest.
See the discussion with Colin Vipurs on the Hamcrest Java mailing list about how to better aid IDE autocomplete: https://groups.google.com/d/msg/hamcrest-java/0x6brgczThc/lF8LDTaneBoJ
from javahamcrest.
OK. How about MatchingX? Less like to include unrelated MatchX types?
from javahamcrest.
Yes. After using the MatchXxx convention a bit I do find that autocomplete brings in too many unrelated suggestions. MatchingXxx would filter them out.
from javahamcrest.
I'm not sure where to put the logical composition operators, such as allOf, anyOf, not, anything().
Maybe we should keep the Matchers class around for those. But "Matchers" doesn't fit the MatchingXxx naming convention. Is that a problem? Or should we introduce a new Matching class just for those, and eventually deprecate and remove Matchers?
In Java 8 they could be static methods of the Matcher interface but in Java 7 we still need a class for them.
from javahamcrest.
I haven't pushed, but I've been moving the match classes into the relevant library subdirectories. Then referencing the most common matches in CoreMatchers. At some point I'll merge the core and library trees.
core now contains combiners and IsEquals which I figure is pretty fundamental.
I suggest we leave Matchers, which is deprecated anyway. Maybe CoreMatchers could become MatchingCore. Not sure.
In Java 8 I think we get method references, so it all becomes easier.
I've also introduced a FunctionalMatcher that uses a function for feature extraction, in prep for Java 8.
S
On 27 Dec 2014, at 21:37, Nat Pryce [email protected] wrote:
I'm not sure where to put the logical composition operators, such as allOf, anyOf, not, anything().
Maybe we should keep the Matchers class around for those. But "Matchers" doesn't fit the MatchingXxx naming convention. Is that a problem? Or should we introduce a new Matching class just for those, and eventually deprecate and remove Matchers?
In Java 8 they could be static methods of the Matcher interface but in Java 7 we still need a class for them.
—
Reply to this email directly or view it on GitHub.
from javahamcrest.
Have you pulled? Because I already did that on the v7.0 / v2.x branch some time ago.
from javahamcrest.
OK. What do you want to do?
I've unpublished my v7.0
We should rename v2.x to v2.0
I'd better stop work for now because I'm getting confused.
S
On 28 Dec 2014, at 19:40, Nat Pryce [email protected] wrote:
Have you pulled? Because I already did that on the v7.0 / v2.x branch some time ago.
—
Reply to this email directly or view it on GitHub.
from javahamcrest.
Don't rename the branches. At least not yet. The branch name is not that important. We can tag and rename it when we do the release.
from javahamcrest.
Related Issues (20)
- assertThat(this.object, hasProperty("booleanName")) fails to match boolean types and renames the property HOT 1
- The matcher contains() is misleading HOT 2
- FR: Matching maps with various type HOT 2
- oss-fuzz integration
- Participitation in Hacktoberfest? HOT 1
- HasProperty Matcher doesn't work with Java Records HOT 4
- assertThat(Int::class.java, typeCompatibleWith(Number::class.java)) in kotlin always fails
- hamcrest matching on actual empty list fails with nosuchmethoderror HOT 1
- Test output Alignment
- record version fails the hasProperty HOT 2
- has property fails with non public class.. not sure if this correct as per java standards of property
- Double "close-to" matcher that uses the ULP.
- GraalVM Native Image support HOT 4
- Inquiry about Project Activity and Future Plans HOT 15
- Compatibility in java versions HOT 2
- Upgrade build to JDK 1.8 bytecode HOT 1
- Upgrade to latest Gradle HOT 1
- Publish to Maven Central using GitHub Actions HOT 7
- Hamcrest v3.1
- Hamcrest v4.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from javahamcrest.