Lotus::Controller and unicorn - Action status codes persist to next HTTP request.

[hanami]

Lotus::Controller and unicorn - Action status codes persist to next HTTP request.

[jodosha]

@baob Hey thanks for reporting this. Are you using lotus-controller as standalone component or inside a Lotus app?

Actions are mutable, in order to make your application safe you must use a new instance for each request. This is handled for you by lotusrb, but not if you use lotus-controller alone.

Please let me know.

[baob]

We are using the two gems (Controller and Router) standalone, we are not using the full lotus app. Can you point me in the right direction please ? I read something yesterday about mutable actions, but what I read suggested that Router would create a new instance every time, so I thought it would not apply to our situation.

This is our routing code:

          Lotus::Router.new do
            get '/subjects/:subject_slug',       to: Actions::SubjectsShow
          end

Is it just a case of adding .new to the class referenced ? Or is there another prefered way to do it ? E.g. I've seen references to using Lotus::Controller.load! but I have no idea where to place that code.

[jodosha]

@baob

You have two solutions:

• You can add a class method for each action .call and do:

def self.call(env)
  new.call(env)
end

See more at: https://github.com/lotus/controller#thread-safety

• Or you can on action naming syntax (to: 'actions#subjects_show)