Framework freeze

[hanami]

Framework freeze

[ukutaht]

A couple questions:

• Should the freeze be irreversible? Should one be able to 'unfreeze' a configuration?
• Is there a simple way to get at every controller and action in an application?
• Shouldn't application boot logic live in the 'lotus' gem?

[jodosha]

@Heruku Hey thanks for those questions.

• Yes, I see this process as irreversible, because it has production environment in mind. The plan is load and then freeze, in order to prevent accidental changes.
• There isn't. What's your use case? We can discuss about this and improve things.
• Code loading and framework duplication aren't thread safe. For this reason the loading context should be thread safe. For instance, Lotus::Loader wraps those operations with a critical section. Now, if this framework is used outside of a full stack application (aka without lotusrb gem), I want to provide a single entry point for developers to trigger. Eg. Lotus::Controller.load!.

[ukutaht]

@jodosha Thanks for the reply, you made things much clearer

I can come up with a couple ways to freeze a single configuration:

• There could be a flag on the configuration class whether it can be mutated (not the cleanest way in my opinion, too many added conditionals and possible errors)
• freeze! method could undefine setter methods (I'd like to stay away from metaprogramming)
• freeze! method could return a new immutable configuration class. A read-only value object that can be derived from the existing configuration.

These are some ideas for freezing a single configuration, but I'm having a hard time seeing how we could freeze all configurations. This is why I asked the second question - to provide a single entry point like Lotus::Controller.load!, we must be able to iterate over all controllers and actions defined to freeze them.

Am I missing something?

[jodosha]

@Heruku So you were asking because of the implementation of this feature, not for an use case that you have. Is that right?

Yes, we definitely need a registry. Lotus::View has it, it powers .load!. Now, when I implemented that mechanism in that framework, it was only because I needed to preload templates and do other preparatory work. However, it only was considering the point of this discussion. In other words, we need to rethink the code for both the libraries.