Giter Site home page Giter Site logo

Some Issues with TickEvent about alkaid HOT 4 CLOSED

hanbings avatar hanbings commented on August 25, 2024
Some Issues with TickEvent

from alkaid.

Comments (4)

hanbings avatar hanbings commented on August 25, 2024

Please check out the new commit. 6301953
I've changed AtomicLong to static because Alkaid will detect duplicate loads and I believe this change will work. Thanks!

from alkaid.

iceBear67 avatar iceBear67 commented on August 25, 2024

Just close this issue with your confidence.

from alkaid.

iceBear67 avatar iceBear67 commented on August 25, 2024

There're still some issues with your new commit.

TickEvent, which should be immutable, varies its tick when a newer one is fired, breaking its immutability. (And it should be immutable.)

Once TickEvent is immutable(or not), an AtomicLong is no longer necessary. Also, events are fired on the Main Thread where you can confidently avoid thread-safe issues, you don't have to use such a wrapper.

Additionally, You'd better use methods like getAndIncrease that guarantee thread-safe(which encourages VM to compile CAS assembly instructions) instead of tick + 1.

from alkaid.

hanbings avatar hanbings commented on August 25, 2024

New commit: 8368a3f
In this commit (and the first two of this) we separated the Event from the Tick / Second counter so that the tick / second inside the Event is no longer mutable.
The problem has been fixed, thanks again!

from alkaid.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.