Comments (3)
Good catch, thank you! I'll correct this the next time I work on this project (which might take a good number of months). If someone wants to create a pull request in the meantime, that would be very appreciated.
Edit: To clarify, I think the problem here is that the documentation is wrong, not the code.
from inotify-rs.
I would not consider this a problem or bad documentation? The underlying EAGAIN
and EWOULDBLOCK
are error codes, but I would not call them error conditions.
As well, the documentation does already clearly state that an empty iterator is returned if nothing is available. It also says to use read_events_blocking
if you want at least one result. EAGAIN
and EWOULDBLOCK
say "nothing is available without blocking". There is in fact no error condition though.
from inotify-rs.
@zacheryph I think you're right, strictly speaking, but in my experience, it usually helps if documentation is as explicit as possible. I don't consider this issue a big deal at all, but I think it would be an improvement if that one sentence were changed.
from inotify-rs.
Related Issues (20)
- Consider reverting #146 at some point HOT 3
- Update MSRV to 1.47
- Unsoudness: reference misalignement HOT 2
- Inotify::read_events does not read all events
- EventStream not working HOT 1
- Version not updated in README HOT 1
- panic when call event_stream HOT 1
- Cutting a release for #171 and #173 HOT 1
- Consider addressing buffer alignment in a more robust way HOT 2
- `Inotify::event_stream` is error-prone HOT 2
- Add separate API for adding/removing watches
- Implement ToOwned for `Event<&'a OsStr>` HOT 9
- Consider using cargo clippy in test workflows HOT 1
- Consider increasing the buffer size for the stream example HOT 2
- Using Inotify::read_events in async context HOT 3
- Is it possible to get full path from Event? HOT 3
- Update minimum supported Rust version HOT 1
- duplicate event reports HOT 9
- Async runtime agnostic. HOT 2
- Bump MSRV to at least 1.56 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from inotify-rs.